Skip to content

reloading does not work with --typescript flag #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cs01 opened this issue Dec 1, 2019 · 2 comments
Closed

reloading does not work with --typescript flag #8055

cs01 opened this issue Dec 1, 2019 · 2 comments

Comments

@cs01
Copy link

cs01 commented Dec 1, 2019

Describe the bug

yarn start development server does not reload (hot reload nor manual reload) when running from a directory structure created with npx create-react-app react-app --typescript

Which terms did you search for in User Guide?

reload

Environment

Environment Info:

  System:
    OS: Linux 4.15 Ubuntu 18.04.3 LTS (Bionic Beaver)
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  Binaries:
    Node: 8.10.0 - /usr/bin/node
    Yarn: 1.19.1 - /usr/bin/yarn
    npm: 3.5.2 - /usr/bin/npm
  Browsers:
    Chrome: 78.0.3904.108
    Firefox: 70.0.1
  npmPackages:
    react: ^16.12.0 => 16.12.0 
    react-dom: ^16.12.0 => 16.12.0 
    react-scripts: 3.1.0 => 3.1.0 
  npmGlobalPackages:
    create-react-app: Not Found

package.json:

{
  "name": "react-app",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@types/jest": "24.0.23",
    "@types/node": "12.12.14",
    "@types/react": "16.9.13",
    "@types/react-dom": "16.9.4",
    "react": "^16.12.0",
    "react-dom": "^16.12.0",
    "react-scripts": "3.2.0",
    "typescript": "3.7.2"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

Steps to reproduce

  1. npx create-react-app react-app --typescript
  2. cd react-app
  3. yarn start
  4. Modify src/App.tsx and save it
  5. Note that the page at localhost:3000 does not reflect the change. Note that manually reloading the page also does not reflect the change.
  6. Killing dev server and running yarn start reflects the changes.

Expected behavior

Changes would be reflected as they are without the --typescript flag.

@heyimalex
Copy link
Contributor

I'm unable to repro using the steps you provided.

@cs01
Copy link
Author

cs01 commented Dec 2, 2019

Thanks for the quick response. I just tried again and I can't reproduce anymore either, so I'll close.

I confirmed this 4 times before posting the issue, so I don't know what was going on, but it was definitely happening on my computer earlier.

@cs01 cs01 closed this as completed Dec 2, 2019
@lock lock bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants