-
-
Notifications
You must be signed in to change notification settings - Fork 27k
No styling default? #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What exactly is a "styling plugin"? That strongly depends on what you're trying to do, but generally all user-land styling plugins (e.g. JSS) work just fine. |
As an example, a simple grid system where I want the user to be able to adjust the gutter/column width. |
That's just normal CSS, you shouldn't over complicate it by using 'styling plugins'. |
Essentially, a |
@mxstbr Let's use the example of Bootstrap. It depends on a lot of different variables that can be user-customized. There are 2 ways to customize these variables today.
I understand that using the "customize" page would work fine, but's it's also a bit of a headache. Every time you want to change a variable you're stuck going through the UI again for every variable. I also understand that create-react-app doesn't have SASS or LESS, so those wouldn't work. Where I'm lost is here: if I want to port Bootstrap for better compatibility with create-react-app, so users can customize these variables within their codebase instead of using the online UI, what should I do? I can't find any recommendation. Should all CSS libraries be making online customization UIs? Is the plan that users wanting to integrate third-party CSS frameworks will forever need to "eject" to get direct variable customization? |
We intend to keep Less/SASS out of scope of this project for now.
I don’t see how why this would require a customization UI or anything. This is not really different from when you want to write a library: you create a package, write some code, add a transpilation step, and then use it in your project if you need to. If you absolutely don’t want to create another package, by all means, add a custom |
If I wanted to make a styling plugin compatible with create-react-app, what expectations could I rely on? Can this be specified more clearly - from the Readme I only gather what I can't do.
The text was updated successfully, but these errors were encountered: