Skip to content

Commit 68fc73f

Browse files
Remove minimist from parsing arguments 🎉
1 parent cfeaf14 commit 68fc73f

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

packages/create-react-app/createReactApp.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ const url = require('url');
4949
const hyperquest = require('hyperquest');
5050
const envinfo = require('envinfo');
5151
const os = require('os');
52-
const minimist = require('minimist');
5352

5453
const packageJson = require('./package.json');
5554

@@ -63,6 +62,15 @@ const errorLogFilePatterns = [
6362

6463
let projectName;
6564

65+
const validateArgs = args => {
66+
let hasSwitch = args.find(arg => arg.includes('-'))
67+
if (hasSwitch) {
68+
let index = args.indexOf(hasSwitch)
69+
args.splice(index, 2)
70+
}
71+
return args
72+
}
73+
6674
const program = new commander.Command(packageJson.name)
6775
.version(packageJson.version)
6876
.arguments('<project-directory>')
@@ -145,7 +153,7 @@ if (program.info) {
145153
}
146154

147155
const hasMultipleProjectNameArgs =
148-
minimist(process.argv.slice(2))._.length > 1;
156+
validateArgs(process.argv.slice(2)).length > 1;
149157
if (typeof projectName === 'undefined' || hasMultipleProjectNameArgs) {
150158
console.log();
151159
if (hasMultipleProjectNameArgs) {

0 commit comments

Comments
 (0)