From 0611465fc8ec4ab6add1da95628a54309053a694 Mon Sep 17 00:00:00 2001 From: exoego Date: Fri, 5 Jun 2020 21:57:53 +0900 Subject: [PATCH 1/2] Add type annotation for public members --- .../src/main/scala/io/scalajs/nodejs/buffer/package.scala | 4 ++-- .../src/main/scala/io/scalajs/nodejs/crypto/package.scala | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/buffer/package.scala b/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/buffer/package.scala index 3c31e7dfd..6eea42f14 100644 --- a/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/buffer/package.scala +++ b/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/buffer/package.scala @@ -71,13 +71,13 @@ package object buffer { * Note that this is a property on the buffer module returned by require('buffer'), not on the * Buffer global or a Buffer instance. */ - val INSPECT_MAX_BYTES = BufferNamespace.INSPECT_MAX_BYTES + val INSPECT_MAX_BYTES: UID = BufferNamespace.INSPECT_MAX_BYTES /** * On 32-bit architectures, this value is (2^30)-1 (~1GB). On 64-bit architectures, this value is (2^31)-1 (~2GB).F * Note that this is a property on the buffer module returned by require('buffer'), not on the Buffer global or a Buffer instance. */ - val kMaxLength = BufferNamespace.kMaxLength + val kMaxLength: Double = BufferNamespace.kMaxLength @js.native @JSImport("buffer", JSImport.Namespace) diff --git a/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/package.scala b/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/package.scala index 1e73caff0..f98798255 100644 --- a/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/package.scala +++ b/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/package.scala @@ -12,6 +12,6 @@ package object crypto { type Callback2[T1, T2] = js.Function3[NodeError, T1, T2, Any] implicit final class CryptoModuleEnrichment(private val crypto: Crypto.type) extends AnyVal { - @inline def Certificate = io.scalajs.nodejs.crypto.Certificate + @inline def Certificate: Certificate.type = io.scalajs.nodejs.crypto.Certificate } } From 6db0c9c29cdddc94d2166ad98e9f68be1de7035e Mon Sep 17 00:00:00 2001 From: exoego Date: Fri, 5 Jun 2020 22:08:58 +0900 Subject: [PATCH 2/2] Avoid cyclic reference --- .../src/main/scala/io/scalajs/nodejs/crypto/package.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/package.scala b/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/package.scala index f98798255..512a5ec07 100644 --- a/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/package.scala +++ b/app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/package.scala @@ -12,6 +12,6 @@ package object crypto { type Callback2[T1, T2] = js.Function3[NodeError, T1, T2, Any] implicit final class CryptoModuleEnrichment(private val crypto: Crypto.type) extends AnyVal { - @inline def Certificate: Certificate.type = io.scalajs.nodejs.crypto.Certificate + @inline def Certificate: io.scalajs.nodejs.crypto.Certificate.type = io.scalajs.nodejs.crypto.Certificate } }