From d90d68d2b42b5878a80c47a95fd6d240cd707efc Mon Sep 17 00:00:00 2001 From: exoego Date: Mon, 1 Jul 2019 15:14:36 +0900 Subject: [PATCH 1/5] Enable scaladoc publishing. --- build.sbt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/build.sbt b/build.sbt index a71049c18..48069342f 100644 --- a/build.sbt +++ b/build.sbt @@ -170,7 +170,7 @@ lazy val publishingSettings = Seq( publishArtifact in Test := false, publishArtifact in (Compile, packageDoc) := true, publishArtifact in (Compile, packageSrc) := true, - publishArtifact in packageDoc := false, + publishArtifact in packageDoc := true, pomIncludeRepository := { _ => false }, @@ -182,7 +182,6 @@ lazy val publishingSettings = Seq( ), publishConfiguration := publishConfiguration.value.withOverwrite(false), publishLocalConfiguration := publishLocalConfiguration.value.withOverwrite(true), - sources in (Compile, doc) := Seq.empty, releaseIgnoreUntrackedFiles := true, releaseProcess := Seq[ReleaseStep]( checkSnapshotDependencies, From 647090593f4882bcab8dde2a87a8db52112406f7 Mon Sep 17 00:00:00 2001 From: exoego Date: Mon, 1 Jul 2019 15:14:55 +0900 Subject: [PATCH 2/5] Fix wrong annotation for scaladoc. --- .../main/scala/io/scalajs/nodejs/console_module/Console.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/current/src/main/scala/io/scalajs/nodejs/console_module/Console.scala b/app/current/src/main/scala/io/scalajs/nodejs/console_module/Console.scala index 97a9169c1..0c6d6190e 100644 --- a/app/current/src/main/scala/io/scalajs/nodejs/console_module/Console.scala +++ b/app/current/src/main/scala/io/scalajs/nodejs/console_module/Console.scala @@ -46,7 +46,7 @@ class Console protected () extends js.Object { * A simple assertion test that verifies whether `value` is truthy. * If it is not, an `AssertionError` is thrown. * If provided, the error `message` is formatted using `util.format()` and used as the error message. - * @value The value tested for being truthy + * @param value The value tested for being truthy * @param optionalParams The arguments passed to the error message */ def assert(value: js.Any, optionalParams: Any*): Unit = js.native From 5484f599b67ca65e5964fab64be152dc1b0e9e0d Mon Sep 17 00:00:00 2001 From: exoego Date: Mon, 1 Jul 2019 15:22:41 +0900 Subject: [PATCH 3/5] Enable API mappings (mainly Scala.js APIs) --- build.sbt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index 48069342f..b375802b9 100644 --- a/build.sbt +++ b/build.sbt @@ -24,7 +24,8 @@ lazy val commonSettings = Seq( scalacOptions in (Compile, doc) ++= Seq( "-Xfatal-warnings", "-no-link-warnings" - ) + ), + autoAPIMappings := true ) lazy val commonScalaJsSettings = Seq( scalacOptions += "-P:scalajs:sjsDefinedByDefault", From aa4e5a2fa9ac29a4a586d65f0e4ee02bfab947c2 Mon Sep 17 00:00:00 2001 From: exoego Date: Mon, 1 Jul 2019 15:39:17 +0900 Subject: [PATCH 4/5] Enable fatal-warnings on compile command, not in doc. --- build.sbt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index b375802b9..f0a310743 100644 --- a/build.sbt +++ b/build.sbt @@ -21,7 +21,10 @@ lazy val commonSettings = Seq( "-language:implicitConversions", "-Xlint" ), - scalacOptions in (Compile, doc) ++= Seq( + scalacOptions in Compile in compile ++= Seq( + "-Xfatal-warnings" + ), + scalacOptions in Compile in doc ++= Seq( "-Xfatal-warnings", "-no-link-warnings" ), From f58c1e9d3cff85a1dc874f3b6030259f7976233f Mon Sep 17 00:00:00 2001 From: exoego Date: Mon, 1 Jul 2019 15:41:10 +0900 Subject: [PATCH 5/5] Check scaladoc error on CI --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 21d2215cb..cef5385d1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,7 +19,7 @@ install: source ~/.nvm/nvm.sh && nvm install $TRAVIS_NODE_VERSION script: - - sbt ++$TRAVIS_SCALA_VERSION scalafmtSbtCheck scalafmtCheck test:scalafmtCheck test + - sbt ++$TRAVIS_SCALA_VERSION scalafmtSbtCheck scalafmtCheck test:scalafmtCheck current/doc core/doc test before_cache: - rm -fv $HOME/.ivy2/.sbt.ivy.lock