From 6e464e150b233dd81276933fbeb303b1f4d8a2fb Mon Sep 17 00:00:00 2001 From: exoego Date: Wed, 1 Jan 2020 15:37:08 +0900 Subject: [PATCH] Fix #110: setReadableEncoding is wrong --- .../main/scala/io/scalajs/nodejs/stream/Stream.scala | 5 +++++ .../io/scalajs/nodejs/stream/ReadableTest.scala | 12 ++++++++++++ 2 files changed, 17 insertions(+) create mode 100644 app/current/src/test/scala/io/scalajs/nodejs/stream/ReadableTest.scala diff --git a/app/current/src/main/scala/io/scalajs/nodejs/stream/Stream.scala b/app/current/src/main/scala/io/scalajs/nodejs/stream/Stream.scala index 65542cb94..ee34d14e6 100644 --- a/app/current/src/main/scala/io/scalajs/nodejs/stream/Stream.scala +++ b/app/current/src/main/scala/io/scalajs/nodejs/stream/Stream.scala @@ -163,8 +163,13 @@ sealed trait IReadable extends LegacyStream { def readable: Boolean = js.native @enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) + @deprecated("Wrong name. Use readableEncoding", "0.9.1") + @JSName("readableEncoding") def setReadableEncoding: String = js.native + @enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) + def readableEncoding: String = js.native + @enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) def readableEnded: Boolean = js.native diff --git a/app/current/src/test/scala/io/scalajs/nodejs/stream/ReadableTest.scala b/app/current/src/test/scala/io/scalajs/nodejs/stream/ReadableTest.scala new file mode 100644 index 000000000..bc35f7d3d --- /dev/null +++ b/app/current/src/test/scala/io/scalajs/nodejs/stream/ReadableTest.scala @@ -0,0 +1,12 @@ +package io.scalajs.nodejs.stream + +import io.scalajs.nodejs.fs.ReadStream +import org.scalatest.funspec.AnyFunSpec + +class ReadableTest extends AnyFunSpec { + describe("Readable") { + it("readableEncoding") { + assert(new ReadStream("package.json").readableEncoding === null) + } + } +}