Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit d7bff5b

Browse files
author
exoego
committed
Fix #110: setReadableEncoding is wrong
1 parent 9eb9008 commit d7bff5b

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

app/current/src/main/scala/io/scalajs/nodejs/stream/Stream.scala

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,13 @@ sealed trait IReadable extends LegacyStream {
163163
def readable: Boolean = js.native
164164

165165
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
166+
@deprecated("Wrong name. Use readableEncoding", "0.9.1")
167+
@JSName("readableEncoding")
166168
def setReadableEncoding: String = js.native
167169

170+
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
171+
def readableEncoding: String = js.native
172+
168173
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
169174
def readableEnded: Boolean = js.native
170175

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package io.scalajs.nodejs.stream
2+
3+
import io.scalajs.nodejs.fs.ReadStream
4+
import org.scalatest.funspec.AnyFunSpec
5+
6+
class ReadableTest extends AnyFunSpec {
7+
describe("Readable") {
8+
it("readableEncoding") {
9+
assert(new ReadStream("package.json").readableEncoding === null)
10+
}
11+
}
12+
}

0 commit comments

Comments
 (0)