Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit 9fcd222

Browse files
authored
Merge pull request #168 from exoego/wrong-eventemitter
Those modules do not extend EventEmitter actually
2 parents 2cb3eec + 597a278 commit 9fcd222

File tree

8 files changed

+8
-18
lines changed

8 files changed

+8
-18
lines changed

app/current/src/main/scala/io/scalajs/nodejs/Assert.scala

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.scalajs.nodejs
22

3-
import io.scalajs.nodejs.events.IEventEmitter
4-
53
import scala.scalajs.js
64
import scala.scalajs.js.annotation.JSImport
75
import scala.scalajs.js.|
@@ -15,7 +13,7 @@ import scala.scalajs.js.|
1513
* methods implemented and exposed by the module.
1614
*/
1715
@js.native
18-
trait Assert extends IEventEmitter {
16+
trait Assert extends js.Object {
1917

2018
/**
2119
* An alias of assert.ok() .

app/current/src/main/scala/io/scalajs/nodejs/events/EventEmitter.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ trait IEventEmitter extends js.Object {
136136
*/
137137
@js.native
138138
@JSImport("events", JSImport.Namespace)
139-
object EventEmitter extends IEventEmitter {
139+
object EventEmitter extends js.Object {
140140

141141
var usingDomains: Boolean = js.native
142142

app/current/src/main/scala/io/scalajs/nodejs/fs/Fs.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package fs
33

44
import com.thoughtworks.{enableIf, enableMembersIf}
55
import io.scalajs.nodejs.buffer.Buffer
6-
import io.scalajs.nodejs.events.IEventEmitter
76

87
import scala.scalajs.js
98
import scala.scalajs.js.annotation.JSImport
@@ -22,7 +21,7 @@ import scala.scalajs.js.|
2221
* or allow them to bubble up.
2322
*/
2423
@js.native
25-
trait Fs extends IEventEmitter with FSConstants {
24+
trait Fs extends js.Object with FSConstants {
2625

2726
/**
2827
* Returns an object containing commonly used constants for file system operations

app/current/src/main/scala/io/scalajs/nodejs/net/Net.scala

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.scalajs.nodejs.net
22

3-
import io.scalajs.nodejs.events.IEventEmitter
4-
53
import scala.scalajs.js
64
import scala.scalajs.js.annotation.JSImport
75

@@ -11,7 +9,7 @@ import scala.scalajs.js.annotation.JSImport
119
* @see https://nodejs.org/api/net.html
1210
*/
1311
@js.native
14-
trait Net extends IEventEmitter {
12+
trait Net extends js.Object {
1513
/////////////////////////////////////////////////////////////////////////////////
1614
// Methods
1715
/////////////////////////////////////////////////////////////////////////////////

app/current/src/main/scala/io/scalajs/nodejs/readline/Readline.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.scalajs.nodejs.readline
22

3-
import io.scalajs.nodejs.events.IEventEmitter
43
import io.scalajs.nodejs.stream.{IReadable, IWritable}
54

65
import scala.scalajs.js
@@ -13,7 +12,7 @@ import scala.scalajs.js.annotation.JSImport
1312
* @see https://nodejs.org/api/readline.html
1413
*/
1514
@js.native
16-
trait Readline extends IEventEmitter {
15+
trait Readline extends js.Object {
1716

1817
/**
1918
* Clears current line of given TTY stream in a specified direction. <tt>dir</tt> should have one of following values:

app/current/src/main/scala/io/scalajs/nodejs/repl/REPL.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.scalajs.nodejs.repl
22

3-
import io.scalajs.nodejs.events.IEventEmitter
43
import io.scalajs.nodejs.stream
54

65
import scala.scalajs.js
@@ -12,7 +11,7 @@ import scala.scalajs.js.annotation.JSImport
1211
* @see https://nodejs.org/api/repl.html#repl_repl
1312
*/
1413
@js.native
15-
trait REPL extends IEventEmitter {
14+
trait REPL extends js.Object {
1615
var REPL_MODE_SLOPPY: js.Symbol = js.native
1716
var REPL_MODE_STRICT: js.Symbol = js.native
1817

app/current/src/main/scala/io/scalajs/nodejs/url/URL.scala

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package io.scalajs.nodejs
22
package url
33

4-
import io.scalajs.nodejs.events.IEventEmitter
5-
64
import scala.scalajs.js
75
import scala.scalajs.js.annotation.JSImport
86
import scala.scalajs.js.|
@@ -107,7 +105,7 @@ class URL(input: String, base: String | URL = js.native) extends js.Object {
107105
*/
108106
@js.native
109107
@JSImport("url", JSImport.Namespace)
110-
object URL extends IEventEmitter {
108+
object URL extends js.Object {
111109

112110
/**
113111
* Take a parsed URL object, and return a formatted URL string.

app/current/src/main/scala/io/scalajs/nodejs/zlib/Zlib.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package io.scalajs.nodejs.zlib
22

33
import com.thoughtworks.enableIf
4-
import io.scalajs.nodejs.events.IEventEmitter
54

65
import scala.scalajs.js
76
import scala.scalajs.js.annotation.JSImport
@@ -12,7 +11,7 @@ import scala.scalajs.js.annotation.JSImport
1211
* @see https://nodejs.org/docs/latest/api/zlib.html
1312
*/
1413
@js.native
15-
trait Zlib extends IEventEmitter with UncategorizedConstants with ZlibConstants {
14+
trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
1615
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
1716
def createBrotliCompress(options: BrotliOptions = js.native): BrotliCompress = js.native
1817

0 commit comments

Comments
 (0)