Disable -Wunused:privates to allow private constructor.

Also enable more lint options for quality.

Author: exoego

app/current/src/main/scala/io/scalajs/nodejs/dgram/Socket.scala

@@ -16,7 +16,7 @@ import scala.scalajs.js.annotation.JSImport
   */
 @js.native
 @JSImport("dgram", "Socket")
-class Socket extends IEventEmitter {
+class Socket private[this] () extends IEventEmitter {
 
   /**
     * Tells the kernel to join a multicast group at the given multicastAddress and multicastInterface using the

core/src/main/scala/io/scalajs/util/PromiseHelper.scala

@@ -261,7 +261,7 @@ object PromiseHelper {
       case Success(_) =>
         val elapsedTime = System.currentTimeMillis - startTime
         println(f"$action took $elapsedTime msecs")
-      case Failure(e) =>
+      case Failure(_) =>
         val elapsedTime = System.currentTimeMillis - startTime
         println(f"$action took $elapsedTime msecs")
     }

project/MySettings.scala

@@ -6,15 +6,46 @@ import sbtrelease.ReleaseStateTransformations._
 
 object MySettings {
 
+  private val lintSettings = Def.setting({
+    val isScala212 = scalaVersion.value.startsWith("2.12")
+    val lints = (Seq(
+      "adapted-args",
+      "nullary-unit",
+      "inaccessible",
+      "nullary-override",
+      "infer-any",
+      "missing-interpolator",
+      "doc-detached",
+      "private-shadow",
+      "type-parameter-shadow",
+      "poly-implicit-overload",
+      "option-implicit",
+      "delayedinit-select",
+      "package-object-classes",
+      "stars-align",
+      "constant"
+    ) ++ Seq(
+      "nonlocal-return",
+      "implicit-not-found",
+      "serial",
+      "valpattern",
+      "eta-zero",
+      "eta-sam",
+      "deprecation"
+    ).filter(_ => !isScala212)).map(s => s"-Xlint:${s}")
+    // no privates to allow private constructor
+    val unused = Seq("imports", "implicits", "locals", "patvars").filter(_ => !isScala212).map(s => s"-Wunused:${s}")
+    lints ++ unused
+  })
+
   lazy val commonSettings = Seq(
     autoCompilerPlugins := true,
     scalacOptions ++= Seq(
       "-deprecation",
       "-unchecked",
       "-feature",
-      "-language:implicitConversions",
-      "-Xlint"
-    ),
+      "-language:implicitConversions"
+    ) ++ lintSettings.value,
     scalacOptions in Compile in compile ++= Seq(
       "-Xfatal-warnings"
     ),