Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit 53db3e2

Browse files
author
exoego
committed
Node.js v8 seems not to throw exception on closed writable
1 parent a4378db commit 53db3e2

File tree

1 file changed

+22
-20
lines changed

1 file changed

+22
-20
lines changed

app/nodejs-v8/src/test/scala/nodejs/ConsoleTest.scala

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,26 +14,28 @@ class ConsoleTest extends FunSpec with BeforeAndAfterEach {
1414
if (Fs.existsSync(logFileName)) Fs.unlinkSync(logFileName)
1515
}
1616

17-
describe("NodeJS v10") {
18-
it("have constructor(stdout, stderr, ignoreErrors) added in v8.0.0") {
19-
val failingWritable = Fs.createWriteStream(logFileName)
20-
failingWritable.close(_ => {})
21-
val looseConsole = new Console(
22-
stdout = failingWritable,
23-
stderr = failingWritable,
24-
ignoreErrors = true
25-
)
26-
looseConsole.log("ok")
27-
28-
val strictConsole = new Console(
29-
stdout = failingWritable,
30-
stderr = failingWritable,
31-
ignoreErrors = false
32-
)
33-
val ex = intercept[JavaScriptException] {
34-
strictConsole.log("ok")
35-
}
36-
assert(ex.getMessage().contains("write after end"))
17+
it("have constructor(stdout, stderr, ignoreErrors) added in v8.0.0") {
18+
val failingWritable = Fs.createWriteStream(logFileName)
19+
failingWritable.close(_ => {})
20+
val looseConsole = new Console(
21+
stdout = failingWritable,
22+
stderr = failingWritable,
23+
ignoreErrors = true
24+
)
25+
looseConsole.log("ok")
26+
}
27+
28+
it("should suppor ignoreErrors") {
29+
assume(TestEnvironment.isExecutedInNode10OrNewer)
30+
val strictConsole = new Console(
31+
stdout = failingWritable,
32+
stderr = failingWritable,
33+
ignoreErrors = false
34+
)
35+
36+
val ex = intercept[JavaScriptException] {
37+
strictConsole.log("ok")
3738
}
39+
assert(ex.getMessage().contains("write after end"))
3840
}
3941
}

0 commit comments

Comments
 (0)