Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit 18dd553

Browse files
authored
Merge pull request #174 from exoego/nodejs-v13-deprecation
Mark members deprecated in Node.js v13
2 parents 6735f00 + c38c55d commit 18dd553

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

app/current/src/main/scala/io/scalajs/nodejs/http/ClientRequest.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,10 @@ import scala.scalajs.js.{Any, |}
3636
class ClientRequest extends stream.Writable {
3737
def aborted: Int | Boolean = js.native
3838

39+
@deprecated("Use request.socket", "Node.js v13.0.0")
3940
def connection: net.Socket = js.native
4041

42+
@deprecated("Use request.writableEnded", "Node.js v13.0.0")
4143
def finished: Boolean = js.native
4244

4345
var maxHeadersCount: Int | Null = js.native

app/current/src/main/scala/io/scalajs/nodejs/http/ServerResponse.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ trait ServerResponse extends stream.Writable {
2121
* Boolean value that indicates whether the response has completed. Starts as false.
2222
* After response.end() executes, the value will be true.
2323
*/
24+
@deprecated("Use response.writableEnd", "Node.js v13.0.0")
2425
def finished: Boolean = js.native
2526

2627
/**

0 commit comments

Comments
 (0)