-
-
Notifications
You must be signed in to change notification settings - Fork 8
Update to Elixir 1.19 #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Something is for sure wrong with the unit tests of |
|
Turns out it was exactly the same thing as in my library: angelikatyborska/doctest_formatter#48
|
jiegillet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it's still in draft, but it looks good to me now.
|
It was still in draft because I was waiting for exercism/elixir-analyzer#457 to be fully passing. All tooling should get merged at the same time. |
5e81bbc to
22f0398
Compare
|
@jiegillet 1.19.4 broke one smoke test and I cannot figure out how to change it so that is passes both locally and on CI 😵 |
I gave it a try, it took me FOREVER to get it working locally, I followed the steps in the dockerfile, but what I missed is that I needed to set the latest version of Elixir and Erlang globally on my machine. I managed to get the same error as on CI, so I adjusted the expected result and committed it. Can you get it to work locally now? |
🤯🤯🤯 That was exactly the thing that I was missing too. THANK YOU. I put it in the README for future generations. |
Before merging, exercism/elixir#1603 needs to be merged and pulled here.