Skip to content

Conversation

@angelikatyborska
Copy link
Member

Before merging, exercism/elixir#1603 needs to be merged and pulled here.

@angelikatyborska angelikatyborska marked this pull request as draft October 21, 2025 15:49
@angelikatyborska angelikatyborska changed the title Update to 1.19 Update to Elixir 1.19 Oct 21, 2025
@angelikatyborska
Copy link
Member Author

Something is for sure wrong with the unit tests of exercism_test_helper, many tests hang for a longer time and then timeout.

@angelikatyborska
Copy link
Member Author

Turns out it was exactly the same thing as in my library: angelikatyborska/doctest_formatter#48

Inspect.Algebra.format started returning strings sometimes. It's supposed to return io_data, which is a string or list of strings, but in the past it always returned a list of strings. Now that it returns strings, it caused an infinite loop where the clause of colorize that calls itself would always match, because is_doc is true for a string, but not for a list of strings. Infinite loop = hanging test.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it's still in draft, but it looks good to me now.

@angelikatyborska angelikatyborska marked this pull request as ready for review November 28, 2025 07:16
@angelikatyborska
Copy link
Member Author

It was still in draft because I was waiting for exercism/elixir-analyzer#457 to be fully passing. All tooling should get merged at the same time.

@angelikatyborska
Copy link
Member Author

@jiegillet 1.19.4 broke one smoke test and I cannot figure out how to change it so that is passes both locally and on CI 😵

@jiegillet
Copy link
Contributor

jiegillet commented Nov 29, 2025

@jiegillet 1.19.4 broke one smoke test and I cannot figure out how to change it so that is passes both locally and on CI 😵

I gave it a try, it took me FOREVER to get it working locally, I followed the steps in the dockerfile, but what I missed is that I needed to set the latest version of Elixir and Erlang globally on my machine. I managed to get the same error as on CI, so I adjusted the expected result and committed it.
The test feedback used to capture %Plot{\n \n} but now it became %Plot{} = plot (came from this commit I think).

Can you get it to work locally now?
Or did I misunderstood and where you trying to change the test itself rather than the expected result?

@angelikatyborska
Copy link
Member Author

I needed to set the latest version of Elixir and Erlang globally on my machine

🤯🤯🤯

That was exactly the thing that I was missing too. THANK YOU. I put it in the README for future generations.

@angelikatyborska angelikatyborska merged commit df4ea7e into main Nov 29, 2025
4 checks passed
@angelikatyborska angelikatyborska deleted the elixir-1-19 branch November 29, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants