Skip to content

Conversation

@pacrob
Copy link
Contributor

@pacrob pacrob commented Oct 24, 2022

What was wrong?

createFilter was camelCase

How was it fixed?

Changed it to create_filter

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the snake-case-createFilter branch from fdc6a01 to 87cf5ab Compare October 24, 2022 21:21
@pacrob pacrob force-pushed the snake-case-createFilter branch from 87cf5ab to 6f9d4e7 Compare October 24, 2022 21:25
@pacrob pacrob requested review from fselmo and kclowes October 24, 2022 21:35
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 looks good to me!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌🏼

@pacrob pacrob merged commit a59bcb3 into ethereum:master Oct 24, 2022
@pacrob pacrob deleted the snake-case-createFilter branch October 24, 2022 22:39
@saadaltafofficial
Copy link

Perfect now atleast we can differ between js and py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants