Skip to content

enable_strict_bytes_type_checking() broken with solidty>=0.5.0 #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fselmo opened this issue Jan 13, 2022 · 0 comments · Fixed by #2797
Closed

enable_strict_bytes_type_checking() broken with solidty>=0.5.0 #2301

fselmo opened this issue Jan 13, 2022 · 0 comments · Fixed by #2797

Comments

@fselmo
Copy link
Collaborator

fselmo commented Jan 13, 2022

What was wrong?

  • enable_strict_bytes_type_checking() seems to be broken when compiling with solidity versions 0.5.0 and above. This was discovered when compiling an updated emitter contract with updated solidity version in PR Parse tuple arguments from event #2211.

  • Steps to reproduce:

    • Use solidity 0.5.0 to compile emitter_old.sol and the status on the transaction receipt to the function will be a 0 (revert). There will be no logs to parse and the test will fail.

How can it be fixed?

  • No details at the moment, but it's looking like enable_strict_bytes_type_checking() needs to be updated to be compatible with newer solidity versions.
@fselmo fselmo changed the title enable_strict_bytes_type_checking() broken with solidty>=0.5.0 enable_strict_bytes_type_checking() broken with solidty>=0.5.0 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant