Skip to content

Fix AsyncEth module typing #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kclowes opened this issue Jun 4, 2021 · 1 comment
Closed

Fix AsyncEth module typing #2013

kclowes opened this issue Jun 4, 2021 · 1 comment

Comments

@kclowes
Copy link
Collaborator

kclowes commented Jun 4, 2021

What was wrong?

Because the eth module is called eth regardless of whether or not it refers to the Eth module or the AsyncEth module, the typing is a little bit funky. Once AsyncEth is completely switched over to mirror the functionality of the Eth module, we can make the eth attr here be Union[AsyncEth, Eth]. Then we can go through and remove type: ignores throughout codebase on all await w3.eth... lines.
@kclowes kclowes mentioned this issue Feb 23, 2022
Closed
1 task
@fselmo
Copy link
Collaborator

fselmo commented Jul 5, 2023 •
edited
Loading

closed by #2819

@fselmo fselmo closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fselmo @kclowes