use request mocker + no need to format logsBloom in eth-tester middleware

- Use request_mocker where we can
- result_processors take care of the formatting... this was causing the ``None`` value for logsBloom to raise when mocked

Author: fselmo

tests/core/eth-module/test_block_api.py

@@ -1,7 +1,4 @@
 import pytest
-from unittest.mock import (
-    Mock,
-)
 
 from eth_utils import (
     to_checksum_address,
@@ -22,7 +19,7 @@ def test_uses_default_block(w3, extra_accounts, wait_for_transaction):
     assert w3.eth.default_block == w3.eth.block_number
 
 
-def test_get_block_formatters_with_null_values(w3, mocker):
+def test_get_block_formatters_with_null_values(w3, request_mocker):
     null_values_block = {
         "baseFeePerGas": None,
         "extraData": None,
@@ -47,13 +44,12 @@ def test_get_block_formatters_with_null_values(w3, mocker):
         "withdrawalsRoot": None,
         "withdrawals": [],
     }
-    mocker.patch("web3.eth.eth.Eth.get_block", return_value=null_values_block)
-
-    received_block = w3.eth.get_block("pending")
+    with request_mocker(w3, mock_results={"eth_getBlockByNumber": null_values_block}):
+        received_block = w3.eth.get_block("pending")
     assert received_block == null_values_block
 
 
-def test_get_block_formatters_with_pre_formatted_values(w3):
+def test_get_block_formatters_with_pre_formatted_values(w3, request_mocker):
     unformatted_values_block = {
         "baseFeePerGas": "0x3b9aca00",
         "extraData": "0x",
@@ -107,10 +103,10 @@ def test_get_block_formatters_with_pre_formatted_values(w3):
         ],
     }
 
-    w3.manager._make_request = Mock()
-    w3.manager._make_request.return_value = {"result": unformatted_values_block}
-
-    received_block = w3.eth.get_block("pending")
+    with request_mocker(
+        w3, mock_results={"eth_getBlockByNumber": unformatted_values_block}
+    ):
+        received_block = w3.eth.get_block("pending")
 
     assert received_block == {
         "baseFeePerGas": int(unformatted_values_block["baseFeePerGas"], 16),

web3/providers/eth_tester/middleware.py

@@ -189,7 +189,6 @@ def is_hexstr(value: Any) -> bool:
 block_result_remapper = apply_key_map(BLOCK_RESULT_KEY_MAPPING)
 
 BLOCK_RESULT_FORMATTERS = {
-    "logsBloom": integer_to_hex,
     "withdrawals": apply_list_to_array_formatter(
         apply_key_map({"validator_index": "validatorIndex"}),
     ),
@@ -270,12 +269,10 @@ def is_hexstr(value: Any) -> bool:
 }
 result_formatters: Optional[Dict[RPCEndpoint, Callable[..., Any]]] = {
     RPCEndpoint("eth_getBlockByHash"): apply_formatter_if(
-        is_dict,
-        compose(block_result_remapper, block_result_formatter),
+        is_dict, compose(block_result_remapper, block_result_formatter)
     ),
     RPCEndpoint("eth_getBlockByNumber"): apply_formatter_if(
-        is_dict,
-        compose(block_result_remapper, block_result_formatter),
+        is_dict, compose(block_result_remapper, block_result_formatter)
     ),
     RPCEndpoint("eth_getBlockTransactionCountByHash"): apply_formatter_if(
         is_dict,