Skip to content

Commit 15d185b

Browse files
committed
Changes from comments on PR #2753
- Reorganize and add comments to ``AsyncEth`` for filter-related, eth-underscored calls.
1 parent be353e5 commit 15d185b

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

web3/eth/async_eth.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,8 @@ async def get_storage_at(
522522
mungers=[BaseEth.filter_munger],
523523
)
524524

525+
# eth_getFilterChanges, eth_getFilterLogs, eth_uninstallFilter
526+
525527
_get_filter_changes: Method[
526528
Callable[[HexStr], Awaitable[List[LogReceipt]]]
527529
] = Method(RPC.eth_getFilterChanges, mungers=[default_root_munger])

web3/eth/main.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@ def sign_munger(
599599
mungers=[BaseEth.filter_munger],
600600
)
601601

602-
# eth_getFilterChanges, eth_getFilterLogs
602+
# eth_getFilterChanges, eth_getFilterLogs, eth_uninstallFilter
603603

604604
get_filter_changes: Method[Callable[[HexStr], List[LogReceipt]]] = Method(
605605
RPC.eth_getFilterChanges, mungers=[default_root_munger]
@@ -609,6 +609,11 @@ def sign_munger(
609609
RPC.eth_getFilterLogs, mungers=[default_root_munger]
610610
)
611611

612+
uninstall_filter: Method[Callable[[HexStr], bool]] = Method(
613+
RPC.eth_uninstallFilter,
614+
mungers=[default_root_munger],
615+
)
616+
612617
# eth_submitHashrate
613618

614619
submit_hashrate: Method[Callable[[int, _Hash32], bool]] = Method(
@@ -627,10 +632,3 @@ def sign_munger(
627632
RPC.eth_submitWork,
628633
mungers=[default_root_munger],
629634
)
630-
631-
# eth_uninstallFilter
632-
633-
uninstall_filter: Method[Callable[[HexStr], bool]] = Method(
634-
RPC.eth_uninstallFilter,
635-
mungers=[default_root_munger],
636-
)

0 commit comments

Comments
 (0)