Skip to content

Commit dddd6ef

Browse files
benmafjl
benma
authored and
fjl
committed
accounts/usbwallet/trezor: expose protobuf package (#17980)
When some of the same messages are redefined anywhere in a Go project, the protobuf package panics (see golang/protobuf#178). Since this package is internal, there is no way to work around it, as one cannot use it directly, but also cannot define the same messages. There is no downside in making the package accessible.
1 parent 2209fed commit dddd6ef

File tree

6 files changed

+1
-1
lines changed

6 files changed

+1
-1
lines changed

‎accounts/usbwallet/trezor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import (
2828
"math/big"
2929

3030
"github.com/ethereum/go-ethereum/accounts"
31-
"github.com/ethereum/go-ethereum/accounts/usbwallet/internal/trezor"
31+
"github.com/ethereum/go-ethereum/accounts/usbwallet/trezor"
3232
"github.com/ethereum/go-ethereum/common"
3333
"github.com/ethereum/go-ethereum/common/hexutil"
3434
"github.com/ethereum/go-ethereum/core/types"

‎accounts/usbwallet/internal/trezor/messages.pb.go renamed to ‎accounts/usbwallet/trezor/messages.pb.go

File renamed without changes.

‎accounts/usbwallet/internal/trezor/messages.proto renamed to ‎accounts/usbwallet/trezor/messages.proto

File renamed without changes.

‎accounts/usbwallet/internal/trezor/trezor.go renamed to ‎accounts/usbwallet/trezor/trezor.go

File renamed without changes.

‎accounts/usbwallet/internal/trezor/types.pb.go renamed to ‎accounts/usbwallet/trezor/types.pb.go

File renamed without changes.

‎accounts/usbwallet/internal/trezor/types.proto renamed to ‎accounts/usbwallet/trezor/types.proto

File renamed without changes.

0 commit comments

Comments
 (0)