Migrate MeetupList to Chakra #8043
Conversation
ImMiguelP
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Thanks for the PR @ImMiguelP. I've noticed a few differences with the prod styles.
Check this page where we are using this component: https://ethereum.org/en/community/events/#meetups
This PR:
Expected (prod):
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Great job so far. I would like to fix the implementation of LinkOverlay.
src/components/MeetupList.tsx
Outdated
| </RightContainer> | ||
| </Item> | ||
| <LinkBox key={idx}> | ||
| <LinkOverlay |
There was a problem hiding this comment.
So, the idea of this LinkOverlay is to wrap only the text you want to behave as the link text. In this case, it would be the {meetup.title}.
LinkBox => should have all the layout styles
LinkOverlay => is the <a> tag that should only wrap the text
There was a problem hiding this comment.
Ok that makes sense thank you. So even though if I wrap the text with LinkOverlay the LinkBox will make the other Box clickable correct? In a sense its kind of like wrapping all the components in a Form?
There was a problem hiding this comment.
Yes exactly, it is useful when you need to create this clickable components (like Cards) which are more than just a text link, and you still want to keep the html semantics in a good shape.
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
3 participants
Description
Migrates
MeetupListcomponent fromemotiontochakra-uiRelated Issue
#6374