Refactor DocLink component to use ChakraUI #7780
Conversation
beamandala
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Thanks for the PR @master7130 🎉
This is looking really good. I've left a few comments to use a bit better the Chakra components. LMK what you think.
Thanks for the suggestions! I'll start making the changes in the areas you pointed out. |
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Thanks for the recent changes @master7130 this is looking great. I left a few more changes that we need to make this work well.
|
Hey @pettinarip can you take a look at my recent changes? |
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
I've detected a few style issues. With those things fixed we should be fine to merge this. Good job @master7130 Thanks for the work you did here 💯
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Great job @master7130!
@master7130 be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!
|
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
|
@all-contributors please add @master7130 for code |
|
I've put up a pull request to add @master7130! 🎉 |
Great! Thanks for guiding me through this! |
2 participants
Description
Converted DocLink.tsx from styled-components to ChakraUI
Related Issue
#6374