Migrate run a node page
#10534
Merged
Migrate run a node page
#10534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
corwintines,
jmcook1186,
minimalsm,
nhsz,
samajammin and
wackerow
as code owners
github-actions
bot
added
content 🖋️
38 tasks
✅ ethereum-org-website-dev deploy preview ready
|
wackerow
approved these changes
Jun 27, 2023
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
I assume this is just part of adopting the design system, just making sure it's intentional we're removing this haze effect.
Also, I noticed the <li> indentation is reduced here... was that intentional?
Neither are blockers in my opinion, just wanted to check, otherwise looks good!
Member
Author
|
@wackerow good catches. No, they were not intentional. I'll take a look at those and fix them. Ty |
pettinarip
force-pushed
the
migrate-run-a-node-page
branch
from
f55c0aa to
aa0701b
Compare
This was referenced Jun 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the Run a node page to Chakra UI.
Related Issue
#9353