Skip to content

Exception should be thrown when schema file is not found #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smilesrg opened this issue Oct 12, 2018 · 5 comments
Closed

Exception should be thrown when schema file is not found #18

smilesrg opened this issue Oct 12, 2018 · 5 comments
Labels

Comments

@smilesrg
Copy link

Currently, if schema file is not found, Assert::assertJsonMatchesSchema() throws an exception JsonSchema\Exception\JsonDecodingException: Control character error, possibly incorrectly encoded. I took hours when I tried to understand what's wrong with schema file I passed instead of being aware of actual error immediately.

@estahn
Copy link
Owner

estahn commented Oct 16, 2018

@smilesrg Thanks. Would you mind providing a pull request with your suggested change?

@stale
Copy link

stale bot commented Dec 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 15, 2018
@smilesrg
Copy link
Author

@estahn as soon as I have free time :)

@stale stale bot removed the wontfix label Dec 17, 2018
@smilesrg
Copy link
Author

@estahn Oh, I see that you did it! Thank you )

@stale
Copy link

stale bot commented Feb 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants