SpiUtils - explicit asm instead of volatile #9256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting rid of volatile arg(s) is must-have for -std=c++20 and later provide helper macros to init & load vars at specific points in code modify existing macros to use c++-style casts & less volatile change locals to plain non-volatile variables, avoid extra memw also fixes unintentional const mask load in (pre_cmd) branch
as noted in implementation, all but sp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting rid of volatile arg(s) is must-have for -std=c++20 and later
provide helper macros to init & load vars at specific points in code
modify existing macros to use c++-style casts & less volatile
change locals to plain non-volatile variables, avoid extra memw
also fixes odd const mask load in (pre_cmd) branch added in #9140
(does not always happen, though. noticed while modifying preamble)