From 37d6e7b0c090995bfe75602d77f3368a79f5b5f3 Mon Sep 17 00:00:00 2001 From: James Stanley Date: Tue, 17 Oct 2017 14:49:16 +0100 Subject: [PATCH 1/3] Put WiFi into station mode in examples I was surprised that many of the example code implicitly creates an unsecured access point with complete access to my application, which was based off the WiFiWebServer example. I'm sure I'm not the only one surprised by this behaviour. Putting the WiFi into station mode prevents the open access point from being created. --- .../examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino | 1 + .../ESP8266HTTPClient/examples/Authorization/Authorization.ino | 1 + .../examples/BasicHttpClient/BasicHttpClient.ino | 1 + .../examples/ReuseConnection/ReuseConnection.ino | 1 + .../examples/StreamHttpClient/StreamHttpClient.ino | 1 + .../examples/LLMNR_Web_Server/LLMNR_Web_Server.ino | 1 + libraries/ESP8266NetBIOS/examples/ESP_NBNST/ESP_NBNST.ino | 1 + .../examples/AdvancedWebServer/AdvancedWebServer.ino | 1 + libraries/ESP8266WebServer/examples/FSBrowser/FSBrowser.ino | 1 + .../ESP8266WebServer/examples/HelloServer/HelloServer.ino | 1 + .../ESP8266WebServer/examples/SDWebServer/SDWebServer.ino | 1 + .../examples/SimpleAuthentification/SimpleAuthentification.ino | 1 + libraries/ESP8266WiFi/examples/HTTPSRequest/HTTPSRequest.ino | 1 + .../examples/HTTPSRequestCACert/HTTPSRequestCACert.ino | 1 + libraries/ESP8266WiFi/examples/NTPClient/NTPClient.ino | 1 + .../ESP8266WiFi/examples/WiFiClientBasic/WiFiClientBasic.ino | 1 + libraries/ESP8266WiFi/examples/WiFiMulti/WiFiMulti.ino | 3 ++- .../examples/WiFiTelnetToSerial/WiFiTelnetToSerial.ino | 1 + libraries/ESP8266WiFi/examples/WiFiWebServer/WiFiWebServer.ino | 1 + libraries/ESP8266httpUpdate/examples/httpUpdate/httpUpdate.ino | 1 + .../examples/httpUpdateSPIFFS/httpUpdateSPIFFS.ino | 1 + .../ESP8266mDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino | 1 + .../ESP8266mDNS/examples/mDNS_Web_Server/mDNS_Web_Server.ino | 1 + 23 files changed, 24 insertions(+), 1 deletion(-) diff --git a/libraries/ESP8266AVRISP/examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino b/libraries/ESP8266AVRISP/examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino index 792d702c9a..6eb59208c2 100644 --- a/libraries/ESP8266AVRISP/examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino +++ b/libraries/ESP8266AVRISP/examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino @@ -17,6 +17,7 @@ void setup() { Serial.println("Arduino AVR-ISP over TCP"); avrprog.setReset(false); // let the AVR run + WiFi.mode(WIFI_STA) WiFi.begin(ssid, pass); while (WiFi.waitForConnectResult() != WL_CONNECTED); diff --git a/libraries/ESP8266HTTPClient/examples/Authorization/Authorization.ino b/libraries/ESP8266HTTPClient/examples/Authorization/Authorization.ino index 64955e56b8..5469249edf 100644 --- a/libraries/ESP8266HTTPClient/examples/Authorization/Authorization.ino +++ b/libraries/ESP8266HTTPClient/examples/Authorization/Authorization.ino @@ -31,6 +31,7 @@ void setup() { delay(1000); } + WiFi.mode(WIFI_STA); WiFiMulti.addAP("SSID", "PASSWORD"); } diff --git a/libraries/ESP8266HTTPClient/examples/BasicHttpClient/BasicHttpClient.ino b/libraries/ESP8266HTTPClient/examples/BasicHttpClient/BasicHttpClient.ino index 5779267163..d4bcf9a511 100644 --- a/libraries/ESP8266HTTPClient/examples/BasicHttpClient/BasicHttpClient.ino +++ b/libraries/ESP8266HTTPClient/examples/BasicHttpClient/BasicHttpClient.ino @@ -31,6 +31,7 @@ void setup() { delay(1000); } + WiFi.mode(WIFI_STA); WiFiMulti.addAP("SSID", "PASSWORD"); } diff --git a/libraries/ESP8266HTTPClient/examples/ReuseConnection/ReuseConnection.ino b/libraries/ESP8266HTTPClient/examples/ReuseConnection/ReuseConnection.ino index c390515bfe..83a9cd1bda 100644 --- a/libraries/ESP8266HTTPClient/examples/ReuseConnection/ReuseConnection.ino +++ b/libraries/ESP8266HTTPClient/examples/ReuseConnection/ReuseConnection.ino @@ -34,6 +34,7 @@ void setup() { delay(1000); } + WiFi.mode(WIFI_STA); WiFiMulti.addAP("SSID", "PASSWORD"); // allow reuse (if server supports it) diff --git a/libraries/ESP8266HTTPClient/examples/StreamHttpClient/StreamHttpClient.ino b/libraries/ESP8266HTTPClient/examples/StreamHttpClient/StreamHttpClient.ino index 7fa1182544..46094370ae 100644 --- a/libraries/ESP8266HTTPClient/examples/StreamHttpClient/StreamHttpClient.ino +++ b/libraries/ESP8266HTTPClient/examples/StreamHttpClient/StreamHttpClient.ino @@ -31,6 +31,7 @@ void setup() { delay(1000); } + WiFi.mode(WIFI_STA); WiFiMulti.addAP("SSID", "PASSWORD"); } diff --git a/libraries/ESP8266LLMNR/examples/LLMNR_Web_Server/LLMNR_Web_Server.ino b/libraries/ESP8266LLMNR/examples/LLMNR_Web_Server/LLMNR_Web_Server.ino index 960b26e9f8..c2231430e4 100644 --- a/libraries/ESP8266LLMNR/examples/LLMNR_Web_Server/LLMNR_Web_Server.ino +++ b/libraries/ESP8266LLMNR/examples/LLMNR_Web_Server/LLMNR_Web_Server.ino @@ -77,6 +77,7 @@ void setup(void) { Serial.begin(115200); // Connect to WiFi network + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); Serial.println(""); diff --git a/libraries/ESP8266NetBIOS/examples/ESP_NBNST/ESP_NBNST.ino b/libraries/ESP8266NetBIOS/examples/ESP_NBNST/ESP_NBNST.ino index 016439b0c1..7642d401f0 100755 --- a/libraries/ESP8266NetBIOS/examples/ESP_NBNST/ESP_NBNST.ino +++ b/libraries/ESP8266NetBIOS/examples/ESP_NBNST/ESP_NBNST.ino @@ -22,6 +22,7 @@ void setup() Serial.begin(115200); // Connect to WiFi network + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); Serial.println(""); diff --git a/libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino b/libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino index 87f96f032d..4df7117f8f 100644 --- a/libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino +++ b/libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino @@ -93,6 +93,7 @@ void setup ( void ) { pinMode ( led, OUTPUT ); digitalWrite ( led, 0 ); Serial.begin ( 115200 ); + WiFi.mode ( WIFI_STA ); WiFi.begin ( ssid, password ); Serial.println ( "" ); diff --git a/libraries/ESP8266WebServer/examples/FSBrowser/FSBrowser.ino b/libraries/ESP8266WebServer/examples/FSBrowser/FSBrowser.ino index 4df717d701..0470099507 100644 --- a/libraries/ESP8266WebServer/examples/FSBrowser/FSBrowser.ino +++ b/libraries/ESP8266WebServer/examples/FSBrowser/FSBrowser.ino @@ -179,6 +179,7 @@ void setup(void){ //WIFI INIT DBG_OUTPUT_PORT.printf("Connecting to %s\n", ssid); if (String(WiFi.SSID()) != String(ssid)) { + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); } diff --git a/libraries/ESP8266WebServer/examples/HelloServer/HelloServer.ino b/libraries/ESP8266WebServer/examples/HelloServer/HelloServer.ino index 2022979ee1..78d314b741 100644 --- a/libraries/ESP8266WebServer/examples/HelloServer/HelloServer.ino +++ b/libraries/ESP8266WebServer/examples/HelloServer/HelloServer.ino @@ -37,6 +37,7 @@ void setup(void){ pinMode(led, OUTPUT); digitalWrite(led, 0); Serial.begin(115200); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); Serial.println(""); diff --git a/libraries/ESP8266WebServer/examples/SDWebServer/SDWebServer.ino b/libraries/ESP8266WebServer/examples/SDWebServer/SDWebServer.ino index 69bcaba90a..aff3ac6771 100644 --- a/libraries/ESP8266WebServer/examples/SDWebServer/SDWebServer.ino +++ b/libraries/ESP8266WebServer/examples/SDWebServer/SDWebServer.ino @@ -223,6 +223,7 @@ void setup(void){ DBG_OUTPUT_PORT.begin(115200); DBG_OUTPUT_PORT.setDebugOutput(true); DBG_OUTPUT_PORT.print("\n"); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); DBG_OUTPUT_PORT.print("Connecting to "); DBG_OUTPUT_PORT.println(ssid); diff --git a/libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino b/libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino index d4762e1be1..139348f531 100644 --- a/libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino +++ b/libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino @@ -95,6 +95,7 @@ void handleNotFound(){ void setup(void){ Serial.begin(115200); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); Serial.println(""); diff --git a/libraries/ESP8266WiFi/examples/HTTPSRequest/HTTPSRequest.ino b/libraries/ESP8266WiFi/examples/HTTPSRequest/HTTPSRequest.ino index 6d10d51156..390fe7e75c 100644 --- a/libraries/ESP8266WiFi/examples/HTTPSRequest/HTTPSRequest.ino +++ b/libraries/ESP8266WiFi/examples/HTTPSRequest/HTTPSRequest.ino @@ -29,6 +29,7 @@ void setup() { Serial.println(); Serial.print("connecting to "); Serial.println(ssid); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); while (WiFi.status() != WL_CONNECTED) { delay(500); diff --git a/libraries/ESP8266WiFi/examples/HTTPSRequestCACert/HTTPSRequestCACert.ino b/libraries/ESP8266WiFi/examples/HTTPSRequestCACert/HTTPSRequestCACert.ino index ddb24f7a49..2fc0f2eb03 100644 --- a/libraries/ESP8266WiFi/examples/HTTPSRequestCACert/HTTPSRequestCACert.ino +++ b/libraries/ESP8266WiFi/examples/HTTPSRequestCACert/HTTPSRequestCACert.ino @@ -37,6 +37,7 @@ void setup() { Serial.println(); Serial.print("connecting to "); Serial.println(ssid); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); while (WiFi.status() != WL_CONNECTED) { delay(500); diff --git a/libraries/ESP8266WiFi/examples/NTPClient/NTPClient.ino b/libraries/ESP8266WiFi/examples/NTPClient/NTPClient.ino index 4176c511b2..2eda6266c8 100644 --- a/libraries/ESP8266WiFi/examples/NTPClient/NTPClient.ino +++ b/libraries/ESP8266WiFi/examples/NTPClient/NTPClient.ino @@ -49,6 +49,7 @@ void setup() // We start by connecting to a WiFi network Serial.print("Connecting to "); Serial.println(ssid); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, pass); while (WiFi.status() != WL_CONNECTED) { diff --git a/libraries/ESP8266WiFi/examples/WiFiClientBasic/WiFiClientBasic.ino b/libraries/ESP8266WiFi/examples/WiFiClientBasic/WiFiClientBasic.ino index accb37bf89..178b2e6614 100644 --- a/libraries/ESP8266WiFi/examples/WiFiClientBasic/WiFiClientBasic.ino +++ b/libraries/ESP8266WiFi/examples/WiFiClientBasic/WiFiClientBasic.ino @@ -13,6 +13,7 @@ void setup() { delay(10); // We start by connecting to a WiFi network + WiFi.mode(WIFI_STA); WiFiMulti.addAP("SSID", "passpasspass"); Serial.println(); diff --git a/libraries/ESP8266WiFi/examples/WiFiMulti/WiFiMulti.ino b/libraries/ESP8266WiFi/examples/WiFiMulti/WiFiMulti.ino index 70803254da..a4aa67823b 100644 --- a/libraries/ESP8266WiFi/examples/WiFiMulti/WiFiMulti.ino +++ b/libraries/ESP8266WiFi/examples/WiFiMulti/WiFiMulti.ino @@ -12,6 +12,7 @@ void setup() { Serial.begin(115200); delay(10); + WiFi.mode(WIFI_STA); wifiMulti.addAP("ssid_from_AP_1", "your_password_for_AP_1"); wifiMulti.addAP("ssid_from_AP_2", "your_password_for_AP_2"); wifiMulti.addAP("ssid_from_AP_3", "your_password_for_AP_3"); @@ -30,4 +31,4 @@ void loop() { Serial.println("WiFi not connected!"); delay(1000); } -} \ No newline at end of file +} diff --git a/libraries/ESP8266WiFi/examples/WiFiTelnetToSerial/WiFiTelnetToSerial.ino b/libraries/ESP8266WiFi/examples/WiFiTelnetToSerial/WiFiTelnetToSerial.ino index 7770cdc29a..fa81508401 100644 --- a/libraries/ESP8266WiFi/examples/WiFiTelnetToSerial/WiFiTelnetToSerial.ino +++ b/libraries/ESP8266WiFi/examples/WiFiTelnetToSerial/WiFiTelnetToSerial.ino @@ -30,6 +30,7 @@ WiFiClient serverClients[MAX_SRV_CLIENTS]; void setup() { Serial1.begin(115200); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); Serial1.print("\nConnecting to "); Serial1.println(ssid); uint8_t i = 0; diff --git a/libraries/ESP8266WiFi/examples/WiFiWebServer/WiFiWebServer.ino b/libraries/ESP8266WiFi/examples/WiFiWebServer/WiFiWebServer.ino index fa40678a43..8ec6522703 100644 --- a/libraries/ESP8266WiFi/examples/WiFiWebServer/WiFiWebServer.ino +++ b/libraries/ESP8266WiFi/examples/WiFiWebServer/WiFiWebServer.ino @@ -30,6 +30,7 @@ void setup() { Serial.print("Connecting to "); Serial.println(ssid); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); while (WiFi.status() != WL_CONNECTED) { diff --git a/libraries/ESP8266httpUpdate/examples/httpUpdate/httpUpdate.ino b/libraries/ESP8266httpUpdate/examples/httpUpdate/httpUpdate.ino index c7da7139bb..683b70a2c6 100644 --- a/libraries/ESP8266httpUpdate/examples/httpUpdate/httpUpdate.ino +++ b/libraries/ESP8266httpUpdate/examples/httpUpdate/httpUpdate.ino @@ -32,6 +32,7 @@ void setup() { delay(1000); } + WiFi.mode(WIFI_STA); WiFiMulti.addAP("SSID", "PASSWORD"); } diff --git a/libraries/ESP8266httpUpdate/examples/httpUpdateSPIFFS/httpUpdateSPIFFS.ino b/libraries/ESP8266httpUpdate/examples/httpUpdateSPIFFS/httpUpdateSPIFFS.ino index 72659cf697..e8856e1184 100644 --- a/libraries/ESP8266httpUpdate/examples/httpUpdateSPIFFS/httpUpdateSPIFFS.ino +++ b/libraries/ESP8266httpUpdate/examples/httpUpdateSPIFFS/httpUpdateSPIFFS.ino @@ -32,6 +32,7 @@ void setup() { delay(1000); } + WiFi.mode(WIFI_STA); WiFiMulti.addAP("SSID", "PASSWORD"); } diff --git a/libraries/ESP8266mDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino b/libraries/ESP8266mDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino index d3feedee56..111b06b4ab 100644 --- a/libraries/ESP8266mDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino +++ b/libraries/ESP8266mDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino @@ -26,6 +26,7 @@ void setup() { Serial.println(hostString); WiFi.hostname(hostString); + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); while (WiFi.status() != WL_CONNECTED) { delay(250); diff --git a/libraries/ESP8266mDNS/examples/mDNS_Web_Server/mDNS_Web_Server.ino b/libraries/ESP8266mDNS/examples/mDNS_Web_Server/mDNS_Web_Server.ino index 710ddcaeae..233506ec9c 100644 --- a/libraries/ESP8266mDNS/examples/mDNS_Web_Server/mDNS_Web_Server.ino +++ b/libraries/ESP8266mDNS/examples/mDNS_Web_Server/mDNS_Web_Server.ino @@ -31,6 +31,7 @@ void setup(void) Serial.begin(115200); // Connect to WiFi network + WiFi.mode(WIFI_STA); WiFi.begin(ssid, password); Serial.println(""); From dd15d2a1b4d672435ec1b7cf704e6c94a2017f32 Mon Sep 17 00:00:00 2001 From: James Stanley Date: Tue, 17 Oct 2017 14:52:45 +0100 Subject: [PATCH 2/3] Spaces => Tabs --- .../examples/AdvancedWebServer/AdvancedWebServer.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino b/libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino index 4df7117f8f..3e87f72e25 100644 --- a/libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino +++ b/libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino @@ -93,7 +93,7 @@ void setup ( void ) { pinMode ( led, OUTPUT ); digitalWrite ( led, 0 ); Serial.begin ( 115200 ); - WiFi.mode ( WIFI_STA ); + WiFi.mode ( WIFI_STA ); WiFi.begin ( ssid, password ); Serial.println ( "" ); From acbee1015944ba79ef94fde6f0ac9a2e3c5d3b27 Mon Sep 17 00:00:00 2001 From: James Stanley Date: Tue, 17 Oct 2017 14:56:53 +0100 Subject: [PATCH 3/3] Put WiFi into station mode in examples I was surprised that many of the examples implicitly create an unsecured access point with complete access to my application, which was based off the WiFiWebServer example. I'm sure I'm not the only one surprised by this behaviour. Putting the WiFi into station mode prevents the open access point from being created. --- .../examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/ESP8266AVRISP/examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino b/libraries/ESP8266AVRISP/examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino index 6eb59208c2..16c829e12d 100644 --- a/libraries/ESP8266AVRISP/examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino +++ b/libraries/ESP8266AVRISP/examples/Arduino_Wifi_AVRISP/Arduino_Wifi_AVRISP.ino @@ -17,7 +17,7 @@ void setup() { Serial.println("Arduino AVR-ISP over TCP"); avrprog.setReset(false); // let the AVR run - WiFi.mode(WIFI_STA) + WiFi.mode(WIFI_STA); WiFi.begin(ssid, pass); while (WiFi.waitForConnectResult() != WL_CONNECTED);