uart: more readable loop

d-a-v · d-a-v · commit de24e9bdc374 · 2018-03-21T17:28:55.000+01:00
diff --git a/cores/esp8266/uart.c b/cores/esp8266/uart.c
@@ -234,10 +234,11 @@ size_t uart_write(uart_t* uart, const char* buf, size_t size)
     if(uart == NULL || !uart->tx_enabled) {
         return 0;
     }
-    for (size_t s = size + 1; --s; ) {
+    size_t ret = size;
+    while (size--) {
         uart_do_write_char(uart, *buf++);
     }
-    return size;
+    return ret;
 }
 
 size_t uart_tx_free(uart_t* uart)

Original file line number	Diff line number	Diff line change
`@@ -234,10 +234,11 @@ size_t uart_write(uart_t* uart, const char* buf, size_t size)`
`234`	`234`	`if(uart == NULL \|\| !uart->tx_enabled) {`
`235`	`235`	`return 0;`
`236`	`236`	`}`
`237`		`- for (size_t s = size + 1; --s; ) {`
	`237`	`+ size_t ret = size;`
	`238`	`+ while (size--) {`
`238`	`239`	`uart_do_write_char(uart, *buf++);`
`239`	`240`	`}`
`240`		`- return size;`
	`241`	`+ return ret;`
`241`	`242`	`}`
`242`	`243`
`243`	`244`	`size_t uart_tx_free(uart_t* uart)`