fix(no-unpublished): allowModules option was disabled when using TS alias (#423)

Author: ota-meshi

lib/util/check-extraneous.js

@@ -38,7 +38,9 @@ exports.checkExtraneous = function checkExtraneous(context, filePath, targets) {
             target.moduleName != null &&
             target.filePath != null &&
             !dependencies.has(target.moduleName) &&
-            !allowed.has(target.moduleName)
+            !allowed.has(target.moduleName) &&
+            // https://github.com/eslint-community/eslint-plugin-n/issues/379
+            !target.hasTSAlias()
         ) {
             context.report({
                 node: target.node,

lib/util/import-target.js

@@ -176,20 +176,6 @@ module.exports = class ImportTarget {
             return "node"
         }
 
-        // This check should be done before the RegExp that checks npm packages,
-        // because `tsconfig.json` aliases may start with `~`, `@` and this will
-        // cause imports using aliases to be treated as npm-module imports
-        // https://github.com/eslint-community/eslint-plugin-n/issues/379
-        if (isTypescript(this.context)) {
-            const aliases = getTSConfigAliases(this.context)
-            if (
-                Array.isArray(aliases) &&
-                aliases.some(alias => this.name.startsWith(alias.name))
-            ) {
-                return "relative"
-            }
-        }
-
         if (/^(@[\w~-][\w.~-]*\/)?[\w~-][\w.~-]*/.test(this.name)) {
             return "npm"
         }
@@ -201,6 +187,19 @@ module.exports = class ImportTarget {
         return "unknown"
     }
 
+    hasTSAlias() {
+        if (isTypescript(this.context)) {
+            const aliases = getTSConfigAliases(this.context)
+            if (
+                Array.isArray(aliases) &&
+                aliases.some(alias => this.name.startsWith(alias.name))
+            ) {
+                return true
+            }
+        }
+        return false
+    }
+
     /**
      * What module import style is used
      * @param {'import' | 'require'} fallback

tests/fixtures/no-unpublished/tsconfig-paths-wildcard/.npmignore

@@ -0,0 +1 @@
+node_modules/*

tests/fixtures/no-unpublished/tsconfig-paths-wildcard/index.ts

@@ -0,0 +1 @@
+// File needs to exists

tests/fixtures/no-unpublished/tsconfig-paths-wildcard/node_modules/@test/dev/index.js

@@ -0,0 +1,7 @@
+{
+    "name": "test",
+    "version": "0.0.0",
+    "devDependencies": {
+        "@test/dev": "0.0.0"
+    }
+}

tests/fixtures/no-unpublished/tsconfig-paths-wildcard/node_modules/@test/dev/package.json

@@ -0,0 +1,7 @@
+{
+    "compilerOptions": {
+        "paths": {
+            "*": ["./node_modules/*"]
+        }
+    }
+}

tests/fixtures/no-unpublished/tsconfig-paths-wildcard/package.json

@@ -155,6 +155,18 @@ ruleTester.run("no-unpublished-import", rule, {
             code: "import type foo from 'foo';",
             options: [{ ignoreTypeImport: true }],
         },
+
+        // imports using `tsconfig.json > compilerOptions > paths` setting
+        // https://github.com/eslint-community/eslint-plugin-n/issues/421
+        {
+            filename: fixture("tsconfig-paths-wildcard/index.ts"),
+            code: "import foo from '@test/dev'",
+            options: [
+                {
+                    allowModules: ["@test/dev"],
+                },
+            ],
+        },
     ],
     invalid: [
         {