Merge pull request mybatis#3138 from dukbong/Refactoring

hazendaz · web-flow · commit e9e9a296000a · 2024-04-14T13:33:16.000-04:00
Use isEmpty() instead of length()
diff --git a/src/main/java/org/apache/ibatis/executor/keygen/SelectKeyGenerator.java b/src/main/java/org/apache/ibatis/executor/keygen/SelectKeyGenerator.java
@@ -65,7 +65,7 @@ private void processGeneratedKeys(Executor executor, MappedStatement ms, Object
         // The transaction will be closed by parent executor.
         Executor keyExecutor = configuration.newExecutor(executor.getTransaction(), ExecutorType.SIMPLE);
         List<Object> values = keyExecutor.query(keyStatement, parameter, RowBounds.DEFAULT, Executor.NO_RESULT_HANDLER);
-        if (values.size() == 0) {
+        if (values.isEmpty()) {
           throw new ExecutorException("SelectKey returned no data.");
         }
         if (values.size() > 1) {

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ private void processGeneratedKeys(Executor executor, MappedStatement ms, Object`
`65`	`65`	`// The transaction will be closed by parent executor.`
`66`	`66`	`Executor keyExecutor = configuration.newExecutor(executor.getTransaction(), ExecutorType.SIMPLE);`
`67`	`67`	`List<Object> values = keyExecutor.query(keyStatement, parameter, RowBounds.DEFAULT, Executor.NO_RESULT_HANDLER);`
`68`		`- if (values.size() == 0) {`
	`68`	`+ if (values.isEmpty()) {`
`69`	`69`	`throw new ExecutorException("SelectKey returned no data.");`
`70`	`70`	`}`
`71`	`71`	`if (values.size() > 1) {`