Skip to content

Conversation

@fabian4
Copy link

@fabian4 fabian4 commented Oct 22, 2025

What type of PR is this?

feat(lint): add kube api linter

What this PR does / why we need it:

add kube api linter

Which issue(s) this PR fixes:

Fixes #6546

Release Notes: Yes/No

@fabian4 fabian4 requested a review from a team as a code owner October 22, 2025 14:09
@fabian4 fabian4 force-pushed the add_kubeapi_linter branch from 37600b4 to cf53708 Compare October 22, 2025 14:13
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.37%. Comparing base (d4e44fd) to head (a3c69f1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/wasm/imagefetcher.go 50.00% 2 Missing ⚠️
internal/gatewayapi/runner/runner.go 66.66% 1 Missing ⚠️
internal/globalratelimit/runner/runner.go 50.00% 1 Missing ⚠️
internal/infrastructure/runner/runner.go 0.00% 1 Missing ⚠️
internal/kubernetes/client.go 0.00% 1 Missing ⚠️
internal/provider/runner/runner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7303      +/-   ##
==========================================
+ Coverage   72.34%   72.37%   +0.03%     
==========================================
  Files         231      231              
  Lines       33896    33896              
==========================================
+ Hits        24521    24533      +12     
+ Misses       7614     7602      -12     
  Partials     1761     1761              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabian4 fabian4 force-pushed the add_kubeapi_linter branch 5 times, most recently from 5ff3ce3 to 811cfdc Compare October 27, 2025 12:12
@fabian4
Copy link
Author

fabian4 commented Oct 27, 2025

For now just added few linters to integrate the ci workflow:

  • "conditions"
  • "nodurations"
  • "nonullable"
  • "notimestamp"
  • "statusoptional"

We call adjust the linters later according to the community need.
👉 https://github.com/kubernetes-sigs/kube-api-linter/blob/main/docs/linters.md

@arkodg
Copy link
Contributor

arkodg commented Oct 27, 2025

cc @rikatz for additional guidance

@fabian4 fabian4 force-pushed the add_kubeapi_linter branch from 811cfdc to a64e3c0 Compare October 28, 2025 14:05
@arkodg
Copy link
Contributor

arkodg commented Oct 28, 2025

thanks @fabian4 , had a few questions

  • curious why the non /api file fixes were needed
  • can you enable all, add the failures in a GH issue, so we can make sure to enable all and fix the issues

@fabian4
Copy link
Author

fabian4 commented Oct 29, 2025

Hi @arkodg

Signed-off-by: fabian4 <[email protected]>
Signed-off-by: fabian4 <[email protected]>
@fabian4 fabian4 force-pushed the add_kubeapi_linter branch from a64e3c0 to a3c69f1 Compare October 30, 2025 14:29
@zirain
Copy link
Member

zirain commented Oct 31, 2025

@fabian4 It would be better if you can move those unrelated changes to a separated PR and rebase this one after it merged.
it will keep this PR as clean as enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add kubeapi linter to make lint

3 participants