Skip to content

Commit d1d9605

Browse files
authored
Remove force Xcode debug workflow (#144185)
Now that all tests are on Xcode 15 and iOS 17, we no longer need to force test Xcode debug workflow. Related flutter/flutter#144020.
1 parent d319625 commit d1d9605

File tree

7 files changed

+8
-186
lines changed

7 files changed

+8
-186
lines changed

.ci.yaml

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -4314,16 +4314,6 @@ targets:
43144314
["devicelab", "ios", "mac"]
43154315
task_name: flavors_test_ios
43164316

4317-
- name: Mac_arm64_ios flavors_test_ios_xcode_debug
4318-
recipe: devicelab/devicelab_drone
4319-
presubmit: false
4320-
timeout: 60
4321-
properties:
4322-
tags: >
4323-
["devicelab", "ios", "mac"]
4324-
task_name: flavors_test_ios_xcode_debug
4325-
bringup: true
4326-
43274317
- name: Mac_arm64_ios flutter_gallery_ios__compile
43284318
recipe: devicelab/devicelab_drone
43294319
presubmit: false
@@ -4342,16 +4332,6 @@ targets:
43424332
["devicelab", "ios", "mac"]
43434333
task_name: flutter_gallery_ios__start_up
43444334

4345-
- name: Mac_ios flutter_gallery_ios__start_up_xcode_debug
4346-
recipe: devicelab/devicelab_drone
4347-
presubmit: false
4348-
timeout: 60
4349-
properties:
4350-
tags: >
4351-
["devicelab", "ios", "mac"]
4352-
task_name: flutter_gallery_ios__start_up_xcode_debug
4353-
bringup: true
4354-
43554335
- name: Mac_ios flutter_view_ios__start_up
43564336
recipe: devicelab/devicelab_drone
43574337
presubmit: false
@@ -4428,16 +4408,6 @@ targets:
44284408
["devicelab", "ios", "mac"]
44294409
task_name: integration_ui_ios_driver
44304410

4431-
- name: Mac_ios integration_ui_ios_driver_xcode_debug
4432-
recipe: devicelab/devicelab_drone
4433-
presubmit: false
4434-
timeout: 60
4435-
properties:
4436-
tags: >
4437-
["devicelab", "ios", "mac"]
4438-
task_name: integration_ui_ios_driver_xcode_debug
4439-
bringup: true
4440-
44414411
- name: Mac_ios integration_ui_ios_frame_number
44424412
recipe: devicelab/devicelab_drone
44434413
presubmit: false
@@ -4553,17 +4523,6 @@ targets:
45534523
["devicelab", "ios", "mac"]
45544524
task_name: microbenchmarks_ios
45554525

4556-
# TODO(vashworth): Remove after Xcode 15 and iOS 17 are in CI (https://github.com/flutter/flutter/issues/132128)
4557-
- name: Mac_ios microbenchmarks_ios_xcode_debug
4558-
recipe: devicelab/devicelab_drone
4559-
presubmit: false
4560-
timeout: 60
4561-
properties:
4562-
tags: >
4563-
["devicelab", "ios", "mac"]
4564-
task_name: microbenchmarks_ios_xcode_debug
4565-
bringup: true
4566-
45674526
- name: Mac native_assets_ios_simulator
45684527
recipe: devicelab/devicelab_drone
45694528
presubmit: false

TESTOWNERS

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,11 +176,9 @@
176176
/dev/devicelab/bin/tasks/cubic_bezier_perf_ios_sksl_warmup__timeline_summary.dart @zanderso @flutter/engine
177177
/dev/devicelab/bin/tasks/external_textures_integration_test_ios.dart @zanderso @flutter/engine
178178
/dev/devicelab/bin/tasks/flavors_test_ios.dart @jmagman @flutter/tool
179-
/dev/devicelab/bin/tasks/flavors_test_ios_xcode_debug.dart @vashworth @flutter/tool
180179
/dev/devicelab/bin/tasks/flutter_gallery__transition_perf_e2e_ios.dart @zanderso @flutter/engine
181180
/dev/devicelab/bin/tasks/flutter_gallery_ios__compile.dart @jmagman @flutter/engine
182181
/dev/devicelab/bin/tasks/flutter_gallery_ios__start_up.dart @vashworth @flutter/engine
183-
/dev/devicelab/bin/tasks/flutter_gallery_ios__start_up_xcode_debug.dart @vashworth @flutter/engine
184182
/dev/devicelab/bin/tasks/flutter_gallery_ios_sksl_warmup__transition_perf.dart @zanderso @flutter/engine
185183
/dev/devicelab/bin/tasks/flutter_view_ios__start_up.dart @zanderso @flutter/engine
186184
/dev/devicelab/bin/tasks/fullscreen_textfield_perf_ios__e2e_summary.dart @vashworth @flutter/engine
@@ -189,7 +187,6 @@
189187
/dev/devicelab/bin/tasks/imagefiltered_transform_animation_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine
190188
/dev/devicelab/bin/tasks/integration_test_test_ios.dart @jmagman @flutter/engine
191189
/dev/devicelab/bin/tasks/integration_ui_ios_driver.dart @vashworth @flutter/tool
192-
/dev/devicelab/bin/tasks/integration_ui_ios_driver_xcode_debug.dart @vashworth @flutter/tool
193190
/dev/devicelab/bin/tasks/integration_ui_ios_frame_number.dart @dnfield @flutter/engine
194191
/dev/devicelab/bin/tasks/integration_ui_ios_keyboard_resize.dart @vashworth @flutter/engine
195192
/dev/devicelab/bin/tasks/integration_ui_ios_screenshot.dart @vashworth @flutter/tool
@@ -200,7 +197,6 @@
200197
/dev/devicelab/bin/tasks/ios_platform_view_tests.dart @stuartmorgan @flutter/plugin
201198
/dev/devicelab/bin/tasks/large_image_changer_perf_ios.dart @zanderso @flutter/engine
202199
/dev/devicelab/bin/tasks/microbenchmarks_ios.dart @vashworth @flutter/engine
203-
/dev/devicelab/bin/tasks/microbenchmarks_ios_xcode_debug.dart @vashworth @flutter/engine
204200
/dev/devicelab/bin/tasks/native_assets_android.dart @dacoharkes @flutter/android
205201
/dev/devicelab/bin/tasks/native_assets_ios.dart @dacoharkes @flutter/ios
206202
/dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart @hellohuanlin @flutter/ios

dev/devicelab/bin/tasks/flavors_test_ios_xcode_debug.dart

Lines changed: 0 additions & 52 deletions
This file was deleted.

dev/devicelab/bin/tasks/flutter_gallery_ios__start_up_xcode_debug.dart

Lines changed: 0 additions & 21 deletions
This file was deleted.

dev/devicelab/bin/tasks/integration_ui_ios_driver_xcode_debug.dart

Lines changed: 0 additions & 21 deletions
This file was deleted.

dev/devicelab/bin/tasks/microbenchmarks_ios_xcode_debug.dart

Lines changed: 0 additions & 21 deletions
This file was deleted.

packages/flutter_tools/lib/src/ios/devices.dart

Lines changed: 8 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -483,17 +483,6 @@ class IOSDevice extends Device {
483483
throwToolExit('Cannot start app on wirelessly tethered iOS device. Try running again with the --publish-port flag');
484484
}
485485

486-
// TODO(vashworth): Remove after Xcode 15 and iOS 17 are in CI (https://github.com/flutter/flutter/issues/132128)
487-
// XcodeDebug workflow is used for CoreDevices (iOS 17+ and Xcode 15+).
488-
// Force the use of XcodeDebug workflow in CI to test from older versions
489-
// since devicelab has not yet been updated to iOS 17 and Xcode 15.
490-
bool forceXcodeDebugWorkflow = false;
491-
if (debuggingOptions.usingCISystem &&
492-
debuggingOptions.debuggingEnabled &&
493-
_platform.environment['FORCE_XCODE_DEBUG']?.toLowerCase() == 'true') {
494-
forceXcodeDebugWorkflow = true;
495-
}
496-
497486
if (!prebuiltApplication) {
498487
_logger.printTrace('Building ${package.name} for $id');
499488

@@ -551,7 +540,7 @@ class IOSDevice extends Device {
551540
);
552541
}
553542

554-
if (isCoreDevice || forceXcodeDebugWorkflow) {
543+
if (isCoreDevice) {
555544
installationResult = await _startAppOnCoreDevice(
556545
debuggingOptions: debuggingOptions,
557546
package: package,
@@ -585,7 +574,7 @@ class IOSDevice extends Device {
585574
_logger.printTrace('Application launched on the device. Waiting for Dart VM Service url.');
586575

587576
final int defaultTimeout;
588-
if ((isCoreDevice || forceXcodeDebugWorkflow) && debuggingOptions.debuggingEnabled) {
577+
if (isCoreDevice && debuggingOptions.debuggingEnabled) {
589578
// Core devices with debugging enabled takes longer because this
590579
// includes time to install and launch the app on the device.
591580
defaultTimeout = isWirelesslyConnected ? 75 : 60;
@@ -620,7 +609,7 @@ class IOSDevice extends Device {
620609
});
621610

622611
Uri? localUri;
623-
if (isCoreDevice || forceXcodeDebugWorkflow) {
612+
if (isCoreDevice) {
624613
localUri = await _discoverDartVMForCoreDevice(
625614
debuggingOptions: debuggingOptions,
626615
packageId: packageId,
@@ -706,7 +695,7 @@ class IOSDevice extends Device {
706695
} finally {
707696
startAppStatus.stop();
708697

709-
if ((isCoreDevice || forceXcodeDebugWorkflow) && debuggingOptions.debuggingEnabled && package is BuildableIOSApp) {
698+
if (isCoreDevice && debuggingOptions.debuggingEnabled && package is BuildableIOSApp) {
710699
// When debugging via Xcode, after the app launches, reset the Generated
711700
// settings to not include the custom configuration build directory.
712701
// This is to prevent confusion if the project is later ran via Xcode
@@ -1138,15 +1127,13 @@ class IOSDeviceLogReader extends DeviceLogReader {
11381127
this._isWirelesslyConnected,
11391128
this._isCoreDevice,
11401129
String appName,
1141-
bool usingCISystem, {
1142-
bool forceXcodeDebug = false,
1143-
}) : // Match for lines for the runner in syslog.
1130+
bool usingCISystem,
1131+
) : // Match for lines for the runner in syslog.
11441132
//
11451133
// iOS 9 format: Runner[297] <Notice>:
11461134
// iOS 10 format: Runner(Flutter)[297] <Notice>:
11471135
_runnerLineRegex = RegExp(appName + r'(\(Flutter\))?\[[\d]+\] <[A-Za-z]+>: '),
1148-
_usingCISystem = usingCISystem,
1149-
_forceXcodeDebug = forceXcodeDebug;
1136+
_usingCISystem = usingCISystem;
11501137

11511138
/// Create a new [IOSDeviceLogReader].
11521139
factory IOSDeviceLogReader.create({
@@ -1165,7 +1152,6 @@ class IOSDeviceLogReader extends DeviceLogReader {
11651152
device.isCoreDevice,
11661153
appName,
11671154
usingCISystem,
1168-
forceXcodeDebug: device._platform.environment['FORCE_XCODE_DEBUG']?.toLowerCase() == 'true',
11691155
);
11701156
}
11711157

@@ -1192,10 +1178,6 @@ class IOSDeviceLogReader extends DeviceLogReader {
11921178
final IMobileDevice _iMobileDevice;
11931179
final bool _usingCISystem;
11941180

1195-
// TODO(vashworth): Remove after Xcode 15 and iOS 17 are in CI (https://github.com/flutter/flutter/issues/132128)
1196-
/// Whether XcodeDebug workflow is being forced.
1197-
final bool _forceXcodeDebug;
1198-
11991181
// Matches a syslog line from the runner.
12001182
RegExp _runnerLineRegex;
12011183

@@ -1309,7 +1291,7 @@ class IOSDeviceLogReader extends DeviceLogReader {
13091291
// However, `idevicesyslog` is sometimes unreliable so use Dart VM as a fallback.
13101292
// Also, `idevicesyslog` does not work with iOS 17 wireless devices, so use the
13111293
// Dart VM for wireless devices.
1312-
if (_isCoreDevice || _forceXcodeDebug) {
1294+
if (_isCoreDevice) {
13131295
if (_isWirelesslyConnected) {
13141296
return _IOSDeviceLogSources(
13151297
primarySource: IOSDeviceLogSource.unifiedLogging,

0 commit comments

Comments
 (0)