Skip to content

Commit 22d206c

Browse files
piotrszymaPiotr Szyma
and
Piotr Szyma
authored
Inherit from faked classes in tests to satisfy mypy (#8859)
* tests: inherit FakeResolverMatcher from django.urls.ResolverMatcher in tests/test_versioning.py * tests: inherit from rest_framework.versioning.BaseVersioning in tests/test_reverse.py * fix: isort --------- Co-authored-by: Piotr Szyma <[email protected]>
1 parent 2db0c0b commit 22d206c

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

tests/test_reverse.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
from rest_framework.reverse import reverse
55
from rest_framework.test import APIRequestFactory
6+
from rest_framework.versioning import BaseVersioning
67

78
factory = APIRequestFactory()
89

@@ -16,7 +17,7 @@ def null_view(request):
1617
]
1718

1819

19-
class MockVersioningScheme:
20+
class MockVersioningScheme(BaseVersioning):
2021

2122
def __init__(self, raise_error=False):
2223
self.raise_error = raise_error

tests/test_versioning.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import pytest
22
from django.test import override_settings
3-
from django.urls import include, path, re_path
3+
from django.urls import ResolverMatch, include, path, re_path
44

55
from rest_framework import serializers, status, versioning
66
from rest_framework.decorators import APIView
@@ -126,7 +126,7 @@ def test_url_path_versioning(self):
126126
assert response.data == {'version': None}
127127

128128
def test_namespace_versioning(self):
129-
class FakeResolverMatch:
129+
class FakeResolverMatch(ResolverMatch):
130130
namespace = 'v1'
131131

132132
scheme = versioning.NamespaceVersioning
@@ -199,7 +199,7 @@ def test_reverse_url_path_versioning(self):
199199
assert response.data == {'url': 'http://testserver/another/'}
200200

201201
def test_reverse_namespace_versioning(self):
202-
class FakeResolverMatch:
202+
class FakeResolverMatch(ResolverMatch):
203203
namespace = 'v1'
204204

205205
scheme = versioning.NamespaceVersioning
@@ -250,7 +250,7 @@ def test_invalid_url_path_versioning(self):
250250
assert response.status_code == status.HTTP_404_NOT_FOUND
251251

252252
def test_invalid_namespace_versioning(self):
253-
class FakeResolverMatch:
253+
class FakeResolverMatch(ResolverMatch):
254254
namespace = 'v3'
255255

256256
scheme = versioning.NamespaceVersioning

0 commit comments

Comments
 (0)