-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Document link/compile/both options #10136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These are documented in settings.js. But perhaps they could also be documented somewhere else? |
Well yes, actually, they definitely could 😄 Then well, they are indeed documented, but they don't specify what I think they should specify: at which step they have an effect (link/compile/both). But again, this holds for all the options documented there, not only this specific one. They should all specify at which step they are required. (And have an official existence in the emscripten docs, but I repeat myself now 😛 ) |
Most of them do. Look for Lines 44 to 47 in 7952394
But I do agree, at a minimum the documentation describing things like |
I believe for main/side module, they are link time, which is the default for flags - so I think the docs in settings.js are accurate (it says near the top that the default is link, if not specified otherwise). |
At some point I hope to start parsing the metadata (e.g. [compile+link]) and warning if you/when the options are used at the wrong time. We perhaps should be extracting the settings.js comments in the docs page. Today we do link directly to the js file here: https://emscripten.org/docs/tools_reference/emcc.html |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
Lets keep this open until these are better documents and we generate runtime warnings when they are mis-used. |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
Generally, every time I'm looking up one of the required Emscripten options for either thing I'm trying to do, in either part of the documentation or wiki, I have generally no idea whether it's required at compile step, at the link step, or both.
Right now, specifically, I'm looking at
-s SIDE_MODULE=1
and-s MAIN_MODULE=1
, but this is basically the case for every single Emscripten option. It's virtually never specified at which step it's required, whereas ideally it would be always specified.So the user ends up needing to fiddle with build scripts, do a full rebuild a bunch of time in order to determine that. If I want to correctly specify my build scripts, I basically am required to do three full rebuilds to determine at which step it was actually needed (and even then I still might not be entirely sure). This is really not ideal.
This is not the first time I'm deeply annoyed by this issue, so I thought I'd at least open an issue.
The text was updated successfully, but these errors were encountered: