Skip to content

Commit beac72f

Browse files
authored
Ensure EH does not change code after linking (#12493)
We used to require Binaryen postprocessing for EH and have a `fail` requirement for it in `other.test_immutable_after_link`. I deleted the requirement in #12399, but it could have been better if I didn't just delete it but changed it to an `ok` requirement. This PR adds that.
1 parent e179b57 commit beac72f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

tests/test_other.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9009,6 +9009,8 @@ def ok(args, filename='hello_world.cpp', expected='hello, world!'):
90099009
ok(required_flags, filename='hello_world_main_loop.cpp')
90109010
# -O1 is ok as we don't run wasm-opt there (but no higher, see below)
90119011
ok(required_flags + ['-O1'])
9012+
# Exception support shouldn't require changes after linking
9013+
ok(required_flags + ['-fexceptions'])
90129014

90139015
# other builds fail with a standard message + extra details
90149016
def fail(args, details):

0 commit comments

Comments
 (0)