Skip to content

Commit 8d4e172

Browse files
authored
embind: Ensure embind works under c++11. (#21100)
We no longer need to test c++17 since that is the default used, but we should ensure we maintain compatibility with c++11.
1 parent 12ee673 commit 8d4e172

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/test_other.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2970,9 +2970,10 @@ def test_embind_closure_no_dynamic_execution(self):
29702970
'wasm64': ['-sMEMORY64', '-Wno-experimental'],
29712971
})
29722972
@parameterized({
2973+
# With no arguments we are effectively testing c++17 since it is the default.
29732974
'': [],
2974-
# Ensure embind compiles under C++17 where "noexcept" became part of the function signature.
2975-
'cxx17': ['-std=c++17'],
2975+
# Ensure embind compiles under C++11 which is the miniumum supported version.
2976+
'cxx11': ['-std=c++11'],
29762977
'o1': ['-O1'],
29772978
'o2': ['-O2'],
29782979
'o2_mem_growth': ['-O2', '-sALLOW_MEMORY_GROWTH', test_file('embind/isMemoryGrowthEnabled=true.cpp')],

0 commit comments

Comments
 (0)