Skip to content

Commit 5a7eb1e

Browse files
committed
.
1 parent 6880b20 commit 5a7eb1e

19 files changed

+148
-168
lines changed

emcc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1262,7 +1262,7 @@ def check(input_file):
12621262

12631263
if shared.Settings.WASM2C or shared.Settings.ASYNCIFY or shared.Settings.EMBIND:
12641264
shared.Settings.USE_LEGACY_DYNCALLS = 1
1265-
shared.Settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += ['$getDynCallerBound']
1265+
shared.Settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += ['$getDynCaller']
12661266

12671267
# Reconfigure the cache now that settings have been applied. Some settings
12681268
# such as LTO and SIDE_MODULE/MAIN_MODULE effect which cache directory we use.

src/Fetch.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -459,28 +459,28 @@ function emscripten_start_fetch(fetch, successcb, errorcb, progresscb, readystat
459459
#if FETCH_DEBUG
460460
console.log('fetch: operation success. e: ' + e);
461461
#endif
462-
if (onsuccess) {{{ makeDynCall('vi') }}}(onsuccess, fetch);
462+
if (onsuccess) {{{ makeDynCall('vi', 'onsuccess') }}}(fetch);
463463
else if (successcb) successcb(fetch);
464464
};
465465

466466
var reportProgress = function(fetch, xhr, e) {
467-
if (onprogress) {{{ makeDynCall('vi') }}}(onprogress, fetch);
467+
if (onprogress) {{{ makeDynCall('vi', 'onprogress') }}}(fetch);
468468
else if (progresscb) progresscb(fetch);
469469
};
470470

471471
var reportError = function(fetch, xhr, e) {
472472
#if FETCH_DEBUG
473473
console.error('fetch: operation failed: ' + e);
474474
#endif
475-
if (onerror) {{{ makeDynCall('vi') }}}(onerror, fetch);
475+
if (onerror) {{{ makeDynCall('vi', 'onerror') }}}(fetch);
476476
else if (errorcb) errorcb(fetch);
477477
};
478478

479479
var reportReadyStateChange = function(fetch, xhr, e) {
480480
#if FETCH_DEBUG
481481
console.log('fetch: ready state change. e: ' + e);
482482
#endif
483-
if (onreadystatechange) {{{ makeDynCall('vi') }}}(onreadystatechange, fetch);
483+
if (onreadystatechange) {{{ makeDynCall('vi', 'onreadystatechange') }}}(fetch);
484484
else if (readystatechangecb) readystatechangecb(fetch);
485485
};
486486

@@ -500,14 +500,14 @@ function emscripten_start_fetch(fetch, successcb, errorcb, progresscb, readystat
500500
#if FETCH_DEBUG
501501
console.log('fetch: IndexedDB store succeeded.');
502502
#endif
503-
if (onsuccess) {{{ makeDynCall('vi') }}}(onsuccess, fetch);
503+
if (onsuccess) {{{ makeDynCall('vi', 'onsuccess') }}}(fetch);
504504
else if (successcb) successcb(fetch);
505505
};
506506
var storeError = function(fetch, xhr, e) {
507507
#if FETCH_DEBUG
508508
console.error('fetch: IndexedDB store failed.');
509509
#endif
510-
if (onsuccess) {{{ makeDynCall('vi') }}}(onsuccess, fetch);
510+
if (onsuccess) {{{ makeDynCall('vi', 'onsuccess') }}}(fetch);
511511
else if (successcb) successcb(fetch);
512512
};
513513
__emscripten_fetch_cache_data(Fetch.dbInstance, fetch, xhr.response, storeSuccess, storeError);

src/library.js

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3867,12 +3867,12 @@ LibraryManager.library = {
38673867

38683868
// libunwind
38693869

3870-
_Unwind_Backtrace__deps: ['emscripten_get_callstack_js', '$getDynCaller'],
3870+
_Unwind_Backtrace__deps: ['emscripten_get_callstack_js'],
38713871
_Unwind_Backtrace: function(func, arg) {
38723872
var trace = _emscripten_get_callstack_js();
38733873
var parts = trace.split('\n');
38743874
for (var i = 0; i < parts.length; i++) {
3875-
var ret = {{{ makeDynCallBound('iii', 'func') }}}(0, arg);
3875+
var ret = {{{ makeDynCall('iii', 'func') }}}(0, arg);
38763876
if (ret !== 0) return;
38773877
}
38783878
},
@@ -3918,11 +3918,10 @@ LibraryManager.library = {
39183918

39193919
// special runtime support
39203920

3921-
emscripten_scan_stack__deps: ['$getDynCaller'],
39223921
emscripten_scan_stack: function(func) {
39233922
var base = STACK_BASE; // TODO verify this is right on pthreads
39243923
var end = stackSave();
3925-
{{{ makeDynCallBound('vii', 'func') }}}(Math.min(base, end), Math.max(base, end));
3924+
{{{ makeDynCall('vii', 'func') }}}(Math.min(base, end), Math.max(base, end));
39263925
},
39273926

39283927
// misc definitions to avoid unnecessary unresolved symbols being reported
@@ -4042,14 +4041,7 @@ LibraryManager.library = {
40424041
},
40434042

40444043
$getDynCaller__deps: ['$dynCall'],
4045-
$getDynCaller: function(sig) {
4046-
return function(ptr) {
4047-
return dynCall(sig, ptr, Array.prototype.slice.call(arguments, 1));
4048-
};
4049-
},
4050-
4051-
$getDynCalleBoundr__deps: ['$dynCall'],
4052-
$getDynCallerBound: function(sig, ptr) {
4044+
$getDynCaller: function(sig, ptr) {
40534045
return function() {
40544046
return dynCall(sig, ptr, Array.prototype.slice.call(arguments));
40554047
};
@@ -4066,9 +4058,9 @@ LibraryManager.library = {
40664058
var func = callback.func;
40674059
if (typeof func === 'number') {
40684060
if (callback.arg === undefined) {
4069-
{{{ makeDynCallBound('v', 'func') }}}();
4061+
{{{ makeDynCall('v', 'func') }}}();
40704062
} else {
4071-
{{{ makeDynCallBound('vi', 'func') }}}(callback.arg);
4063+
{{{ makeDynCall('vi', 'func') }}}(callback.arg);
40724064
}
40734065
} else {
40744066
func(callback.arg === undefined ? null : callback.arg);

src/library_async.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,15 +340,14 @@ mergeInto(LibraryManager.library, {
340340
});
341341
},
342342

343-
emscripten_scan_registers__deps: ['$getDynCaller'],
344343
emscripten_scan_registers: function(func) {
345344
Asyncify.handleSleep(function(wakeUp) {
346345
// We must first unwind, so things are spilled to the stack. We
347346
// can resume right after unwinding, no need for a timeout.
348347
Asyncify.afterUnwind = function() {
349348
var stackBegin = Asyncify.currData + {{{ C_STRUCTS.asyncify_data_s.__size__ }}};
350349
var stackEnd = HEAP32[Asyncify.currData >> 2];
351-
{{{ makeDynCall('vii') }}}(func, stackBegin, stackEnd);
350+
{{{ makeDynCall('vii', 'func') }}}(stackBegin, stackEnd);
352351
wakeUp();
353352
};
354353
});
@@ -365,7 +364,7 @@ mergeInto(LibraryManager.library, {
365364
});
366365
},
367366

368-
$Fibers__deps: ['$Asyncify', '$getDynCaller'],
367+
$Fibers__deps: ['$Asyncify'],
369368
$Fibers: {
370369
nextFiber: 0,
371370
trampolineRunning: false,
@@ -409,7 +408,7 @@ mergeInto(LibraryManager.library, {
409408
{{{ makeSetValue('newFiber', C_STRUCTS.emscripten_fiber_s.entry, 0, 'i32') }}};
410409

411410
var userData = {{{ makeGetValue('newFiber', C_STRUCTS.emscripten_fiber_s.user_data, 'i32') }}};
412-
{{{ makeDynCall('vi') }}}(entryPoint, userData);
411+
{{{ makeDynCall('vi', 'entryPoint') }}}(userData);
413412
} else {
414413
var asyncifyData = newFiber + {{{ C_STRUCTS.emscripten_fiber_s.asyncify_data }}};
415414
Asyncify.currData = asyncifyData;

src/library_browser.js

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -831,7 +831,7 @@ var LibraryBrowser = {
831831
function doCallback(callback) {
832832
if (callback) {
833833
var stack = stackSave();
834-
{{{ makeDynCallBound('vi', 'callback') }}}(allocate(intArrayFromString(_file), 'i8', ALLOC_STACK));
834+
{{{ makeDynCall('vi', 'callback') }}}(allocate(intArrayFromString(_file), 'i8', ALLOC_STACK));
835835
stackRestore(stack);
836836
}
837837
}
@@ -895,10 +895,10 @@ var LibraryBrowser = {
895895
Browser.asyncLoad(UTF8ToString(url), function(byteArray) {
896896
var buffer = _malloc(byteArray.length);
897897
HEAPU8.set(byteArray, buffer);
898-
{{{ makeDynCallBound('viii', 'onload') }}}(arg, buffer, byteArray.length);
898+
{{{ makeDynCall('viii', 'onload') }}}(arg, buffer, byteArray.length);
899899
_free(buffer);
900900
}, function() {
901-
if (onerror) {{{ makeDynCallBound('vi', 'onerror') }}}(arg);
901+
if (onerror) {{{ makeDynCall('vi', 'onerror') }}}(arg);
902902
}, true /* no need for run dependency, this is async but will not do any prepare etc. step */ );
903903
},
904904

@@ -936,27 +936,27 @@ var LibraryBrowser = {
936936
FS.createDataFile( _file.substr(0, index), _file.substr(index + 1), new Uint8Array(/** @type{ArrayBuffer}*/(http.response)), true, true, false);
937937
if (onload) {
938938
var stack = stackSave();
939-
{{{ makeDynCallBound('viii', 'onload') }}}(handle, arg, allocate(intArrayFromString(_file), 'i8', ALLOC_STACK));
939+
{{{ makeDynCall('viii', 'onload') }}}(handle, arg, allocate(intArrayFromString(_file), 'i8', ALLOC_STACK));
940940
stackRestore(stack);
941941
}
942942
} else {
943-
if (onerror) {{{ makeDynCallBound('viii', 'onerror') }}}(handle, arg, http.status);
943+
if (onerror) {{{ makeDynCall('viii', 'onerror') }}}(handle, arg, http.status);
944944
}
945945

946946
delete Browser.wgetRequests[handle];
947947
};
948948

949949
// ERROR
950950
http.onerror = function http_onerror(e) {
951-
if (onerror) {{{ makeDynCallBound('viii', 'onerror') }}}(handle, arg, http.status);
951+
if (onerror) {{{ makeDynCall('viii', 'onerror') }}}(handle, arg, http.status);
952952
delete Browser.wgetRequests[handle];
953953
};
954954

955955
// PROGRESS
956956
http.onprogress = function http_onprogress(e) {
957957
if (e.lengthComputable || (e.lengthComputable === undefined && e.total != 0)) {
958958
var percentComplete = (e.loaded / e.total)*100;
959-
if (onprogress) {{{ makeDynCallBound('viii', 'onprogress') }}}(handle, arg, percentComplete);
959+
if (onprogress) {{{ makeDynCall('viii', 'onprogress') }}}(handle, arg, percentComplete);
960960
}
961961
};
962962

@@ -997,25 +997,25 @@ var LibraryBrowser = {
997997
var byteArray = new Uint8Array(/** @type{ArrayBuffer} */(http.response));
998998
var buffer = _malloc(byteArray.length);
999999
HEAPU8.set(byteArray, buffer);
1000-
if (onload) {{{ makeDynCallBound('viiii', 'onload') }}}(handle, arg, buffer, byteArray.length);
1000+
if (onload) {{{ makeDynCall('viiii', 'onload') }}}(handle, arg, buffer, byteArray.length);
10011001
if (free) _free(buffer);
10021002
} else {
1003-
if (onerror) {{{ makeDynCallBound('viiii', 'onerror') }}}(handle, arg, http.status, http.statusText);
1003+
if (onerror) {{{ makeDynCall('viiii', 'onerror') }}}(handle, arg, http.status, http.statusText);
10041004
}
10051005
delete Browser.wgetRequests[handle];
10061006
};
10071007

10081008
// ERROR
10091009
http.onerror = function http_onerror(e) {
10101010
if (onerror) {
1011-
{{{ makeDynCallBound('viiii', 'onerror') }}}(handle, arg, http.status, http.statusText);
1011+
{{{ makeDynCall('viiii', 'onerror') }}}(handle, arg, http.status, http.statusText);
10121012
}
10131013
delete Browser.wgetRequests[handle];
10141014
};
10151015

10161016
// PROGRESS
10171017
http.onprogress = function http_onprogress(e) {
1018-
if (onprogress) {{{ makeDynCallBound('viiii', 'onprogress') }}}(handle, arg, e.loaded, e.lengthComputable || e.lengthComputable === undefined ? e.total : 0);
1018+
if (onprogress) {{{ makeDynCall('viiii', 'onprogress') }}}(handle, arg, e.loaded, e.lengthComputable || e.lengthComputable === undefined ? e.total : 0);
10191019
};
10201020

10211021
// ABORT
@@ -1059,10 +1059,10 @@ var LibraryBrowser = {
10591059
PATH.basename(_file),
10601060
new Uint8Array(data.object.contents), true, true,
10611061
function() {
1062-
if (onload) {{{ makeDynCallBound('vi', 'onload') }}}(file);
1062+
if (onload) {{{ makeDynCall('vi', 'onload') }}}(file);
10631063
},
10641064
function() {
1065-
if (onerror) {{{ makeDynCallBound('vi', 'onerror') }}}(file);
1065+
if (onerror) {{{ makeDynCall('vi', 'onerror') }}}(file);
10661066
},
10671067
true // don'tCreateFile - it's already there
10681068
);
@@ -1086,10 +1086,10 @@ var LibraryBrowser = {
10861086
{{{ makeHEAPView('U8', 'data', 'data + size') }}},
10871087
true, true,
10881088
function() {
1089-
if (onload) {{{ makeDynCallBound('vii', 'onload') }}}(arg, cname);
1089+
if (onload) {{{ makeDynCall('vii', 'onload') }}}(arg, cname);
10901090
},
10911091
function() {
1092-
if (onerror) {{{ makeDynCallBound('vi', 'onerror') }}}(arg);
1092+
if (onerror) {{{ makeDynCall('vi', 'onerror') }}}(arg);
10931093
},
10941094
true // don'tCreateFile - it's already there
10951095
);
@@ -1196,10 +1196,10 @@ var LibraryBrowser = {
11961196
return 0;
11971197
},
11981198

1199-
emscripten_set_main_loop__deps: ['$setMainLoop', '$getDynCaller'],
1199+
emscripten_set_main_loop__deps: ['$setMainLoop'],
12001200
emscripten_set_main_loop__docs: '/** @param {number|boolean=} noSetTiming */',
12011201
emscripten_set_main_loop: function(func, fps, simulateInfiniteLoop, arg, noSetTiming) {
1202-
var browserIterationFunc = function() { {{{ makeDynCallBound('v', 'func') }}}(); };
1202+
var browserIterationFunc = function() { {{{ makeDynCall('v', 'func') }}}(); };
12031203
setMainLoop(browserIterationFunc, fps, simulateInfiniteLoop, arg, noSetTiming);
12041204
},
12051205

@@ -1334,7 +1334,7 @@ var LibraryBrowser = {
13341334
// Runs natively in pthread, no __proxy needed.
13351335
emscripten_set_main_loop_arg__deps: ['$setMainLoop'],
13361336
emscripten_set_main_loop_arg: function(func, arg, fps, simulateInfiniteLoop) {
1337-
var browserIterationFunc = function() { {{{ makeDynCallBound('vi', 'func') }}}(arg); };
1337+
var browserIterationFunc = function() { {{{ makeDynCall('vi', 'func') }}}(arg); };
13381338
setMainLoop(browserIterationFunc, fps, simulateInfiniteLoop, arg);
13391339
},
13401340

@@ -1357,15 +1357,15 @@ var LibraryBrowser = {
13571357
// Runs natively in pthread, no __proxy needed.
13581358
_emscripten_push_main_loop_blocker: function(func, arg, name) {
13591359
Browser.mainLoop.queue.push({ func: function() {
1360-
{{{ makeDynCallBound('vi', 'func') }}}(arg);
1360+
{{{ makeDynCall('vi', 'func') }}}(arg);
13611361
}, name: UTF8ToString(name), counted: true });
13621362
Browser.mainLoop.updateStatus();
13631363
},
13641364

13651365
// Runs natively in pthread, no __proxy needed.
13661366
_emscripten_push_uncounted_main_loop_blocker: function(func, arg, name) {
13671367
Browser.mainLoop.queue.push({ func: function() {
1368-
{{{ makeDynCallBound('vi', 'func') }}}(arg);
1368+
{{{ makeDynCall('vi', 'func') }}}(arg);
13691369
}, name: UTF8ToString(name), counted: false });
13701370
Browser.mainLoop.updateStatus();
13711371
},
@@ -1382,7 +1382,7 @@ var LibraryBrowser = {
13821382
noExitRuntime = true;
13831383

13841384
function wrapper() {
1385-
{{{ makeDynCallBound('vi', 'func') }}}(arg);
1385+
{{{ makeDynCall('vi', 'func') }}}(arg);
13861386
}
13871387

13881388
if (millis >= 0) {

src/library_exceptions.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ var LibraryExceptions = {
179179
info.add_ref();
180180
},
181181

182-
$exception_decRef__deps: ['__cxa_free_exception', '$getDynCaller',
182+
$exception_decRef__deps: ['__cxa_free_exception',
183183
#if EXCEPTION_DEBUG
184184
, '$exceptionLast', '$exceptionCaught'
185185
#endif
@@ -195,7 +195,7 @@ var LibraryExceptions = {
195195
var destructor = info.get_destructor();
196196
if (destructor) {
197197
// In Wasm, destructors return 'this' as in ARM
198-
{{{ makeDynCallBound('ii', 'destructor') }}}(info.excPtr);
198+
{{{ makeDynCall('ii', 'destructor') }}}(info.excPtr);
199199
}
200200
___cxa_free_exception(info.excPtr);
201201
#if EXCEPTION_DEBUG

0 commit comments

Comments
 (0)