Skip to content

Commit 42f4492

Browse files
authored
Error on use of fastcomp (#11831)
See #11319
1 parent 0c667ed commit 42f4492

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ executors:
1313
EMCC_CORES: "4"
1414
EMSDK_NOTTY: "1"
1515
PYTHON_BIN: "python3"
16+
EMCC_ALLOW_FASTCOMP: "1"
1617
mac:
1718
environment:
1819
EMSDK_NOTTY: "1"

emcc.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1278,10 +1278,11 @@ def get_last_setting_change(setting):
12781278
# we also do not support standalone mode in fastcomp.
12791279
shared.Settings.STANDALONE_WASM = 1
12801280

1281-
# We allow this warning to be supressed by the environment so that we can run the test
1282-
# suite against fastcomp while supressing this warning.
1281+
# We allow this error to be supressed by the environment so that we can run the test
1282+
# suite against fastcomp for the time being.
1283+
# See: https://github.com/emscripten-core/emscripten/issues/11319
12831284
if not shared.Settings.WASM_BACKEND and 'EMCC_ALLOW_FASTCOMP' not in os.environ:
1284-
diagnostics.warning('fastcomp', 'the fastomp compiler is deprecated. Please switch to the upstream llvm backend as soon as possible and open issues if you have trouble doing so')
1285+
exit_with_error('the fastcomp compiler is no longer available in emscripten. Please use the upstream llvm backend or use an older (< 2.0.0) version of emscripten.')
12851286

12861287
if options.no_entry or ('_main' not in shared.Settings.EXPORTED_FUNCTIONS and
12871288
'__start' not in shared.Settings.EXPORTED_FUNCTIONS):

0 commit comments

Comments
 (0)