Fix issue & add test case for multiple CallExpression case

Author: jbandura

lib/rules/no-component-lifecycle-hooks.js

@@ -30,7 +30,7 @@ module.exports = {
 
   create(context) {
     let isInsideEmberComponent = false;
-    let currentComponent = null;
+    let currentEmberComponent = null;
 
     const isAClassicLifecycleHook = keyName => {
       return isComponentLifecycleHook(keyName) && isInsideEmberComponent;
@@ -43,15 +43,21 @@ module.exports = {
       },
 
       CallExpression(node) {
-        isInsideEmberComponent = emberUtils.isEmberComponent(context, node);
+        if (isEmberComponent(context, node)) {
+          currentEmberComponent = node;
+          isInsideEmberComponent = true;
+        }
       },
 
       'ClassDeclaration:exit'() {
         isInsideEmberComponent = false;
       },
 
-      'CallExpression:exit'() {
-        isInsideEmberComponent = false;
+      'CallExpression:exit'(node) {
+        if (currentEmberComponent === node) {
+          currentEmberComponent = null;
+          isInsideEmberComponent = false;
+        }
       },
 
       MethodDefinition(node) {
@@ -61,7 +67,6 @@ module.exports = {
       },
 
       Property(node) {
-        // TODO: fix
         if (isAClassicLifecycleHook(node)) {
           report(context, node.key);
         }

tests/lib/rules/no-component-lifecycle-hooks.js

@@ -128,5 +128,22 @@ ruleTester.run('no-component-lifecycle-hooks', rule, {
         },
       ],
     },
+    {
+      code: `
+        import Component from "@glimmer/component";
+
+        export const Component1 = Component.extend({
+          test: computed('', function () {}),
+          didDestroyElement() {},
+        });
+      `,
+      output: null,
+      errors: [
+        {
+          message: ERROR_MESSAGE,
+          type: 'Identifier',
+        },
+      ],
+    },
   ],
 });