textDocument/codeCompletions not called

[gdevanla]

I see this unexpected behavior while trying to complete {-# LANGUAGE <my_cursor_here #-}.

I noticed, that when inside {- -} , the textDocument/codeCompletions request is not being sent to the server. I tried this functionality with VS Code and latest version of hls/ghcide and everything works. This seems to only be a problem with Emacs lsp. I wonder if this ticket belongs here or should we post this to the core emacs-lsp issue list.

[michaelpj]

Hmmm, this tickled my memory, and I dug up emacs-lsp/lsp-mode#2215. It looks like there's a client setting completion-in-comments?, which we should probably set to t, if HLS actually supports completion in comments (which it sounds like it does).

[gdevanla]

Awesome. I tried with the change and it works. Can I submit a PR for that?

[michaelpj]

Fantastic!