make citar-org support embark-dwim

[tshu-w]

currently if I run embark-dwim on org citation, I got

  nil("peeters_cross-language_2021")
  #f(compiled-function () #<bytecode 0x1a7da90d012d516>)()
  embark--quit-and-run(#f(compiled-function () #<bytecode 0x1a7da90d012d516>))
  embark--act(nil (:orig-type oc-citation :orig-target "peeters_cross-language_2021" :bounds nil :type oc-citation :target "peeters_cross-language_2021") t)
  embark-dwim(nil)
  #<subr funcall-interactively>(embark-dwim nil)
  apply(#<subr funcall-interactively> (embark-dwim nil))
  funcall-interactively(embark-dwim nil)
  #<subr call-interactively>(embark-dwim nil nil)
  apply(#<subr call-interactively> (embark-dwim nil nil))
  explain-pause--wrap-call-interactively(#<subr call-interactively> embark-dwim nil nil)
  apply(explain-pause--wrap-call-interactively #<subr call-interactively> (embark-dwim nil nil))
  call-interactively(embark-dwim nil nil)
  command-execute(embark-dwim)

should we add default action(ENTER) in citar-org-map?

[bdarcus]

currently if I run embark-dwim on org citation, I got

Seems there's other things wrong with your config then ;-)

It works for me, and mouse-clicking on a citation runs it, while right-clicking runs embark-act.

should we add default action(ENTER) in citar-org-map?

Probably.

IIRC, I removed it awhile back before there was some bug with it I couldn't figure out.

[tshu-w]

currently if I run embark-dwim on org citation, I got

Seems there's other things wrong with your config then ;-)

It works for me, and mouse-clicking on a citation runs it, while right-clicking runs embark-act.

should we add default action(ENTER) in citar-org-map?

Probably.

IIRC, I removed it awhile back before there was some bug with it I couldn't figure out.

embark-act work, not embark-dwim

[bdarcus]

Oh, you're right: i can reproduce that!

So embark-act and citar-dwim work correctly; it's just not embark-dwim.

Should probably be an easy fix.

[bdarcus]

Should probably be an easy fix.

I played with this a bit, and couldn't get it to work.

Will try again later.

[tshu-w]

I originally thought that adding the ENTER binding would be enough, but it seems more complicated than I thought 😂

[tshu-w]

I originally thought that adding the ENTER binding would be enough, but it seems more complicated than I thought 😂

Yes, mbark--default-action look RET in the action keymap
https://github.com/oantolin/embark/blob/master/embark.el#L1754

[bdarcus]

I know, but it doesn't work here.

[tshu-w]

i will look at it if i have time

[bdarcus]

While you're working on #394, @roshanshariff, can you see if you can figure this out?

[roshanshariff]

This should be fixed by #394. Currently citar-org-map doesn't have a binding for RET, so there's no default action. In #394 we remove the Org-specific keymap in favour of using citar-buffer-map (which is renamed to citar-citation-map). That has a default action citar-run-default-action.