Skip to content

Commit 2becbfe

Browse files
committed
Add TODOs
1 parent 22a51d4 commit 2becbfe

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lib/elixir/lib/module/types/descr.ex

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1116,6 +1116,7 @@ defmodule Module.Types.Descr do
11161116
{:badarg, domain_to_flat_args(domain, arity)}
11171117

11181118
not subtype?(args_domain, domain) ->
1119+
# TODO: This compatibility check is not enough
11191120
if static? or not compatible?(fun, fun(arguments, term())) do
11201121
{:badarg, domain_to_flat_args(domain, arity)}
11211122
else
@@ -1126,6 +1127,7 @@ defmodule Module.Types.Descr do
11261127
{:ok, fun_apply_static(arguments, static_arrows, false)}
11271128

11281129
static_arrows == [] ->
1130+
# TODO: We need to validate this within the theory
11291131
{:ok, dynamic(fun_apply_static(arguments, dynamic_arrows, false))}
11301132

11311133
true ->

0 commit comments

Comments
 (0)