Fix issues creating a new window #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeremypw
commented
Jul 18, 2023
jeremypw
commented
- Do not create default tab unnecessarily
- Remove tab from old window when appropriate
- View background action has same effect as tab action (same shortcut)
- Avoid same name for action and function
added 2 commits
July 18, 2023 10:44
* Disambiguate name * Move not copy tab to new window * Fix removing content * Fix action win.tab::WINDOW
danirabbit
reviewed
Jul 18, 2023
danirabbit
reviewed
Jul 18, 2023
danirabbit
requested changes
Jul 18, 2023
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Works as expected, just a couple comment about the action name change
Contributor
Author
|
Thanks for spotting the unchanged action names! |
danirabbit
approved these changes
Jul 18, 2023
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Perfect, thank you for helping me finish this branch!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.