Skip to content

stable name for withheld #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BillCarsonFr merged 3 commits into from
Jul 21, 2022
Merged

stable name for withheld #6520

BillCarsonFr merged 3 commits into from
Jul 21, 2022

Conversation

@BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jul 12, 2022 •
edited
Loading

Type of change

  • Bugfix

Content

Fixes #5115
Stop using unstable names for withheld codes #2233

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr requested review from a team and mnaturel and removed request for a team July 12, 2022 07:36
@BillCarsonFr BillCarsonFr mentioned this pull request Jul 12, 2022
Merged
mnaturel
mnaturel approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I didn't do any tests on device.

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/stable_withheld branch from 7c41f16 to f5b3408 Compare July 15, 2022 12:53
@BillCarsonFr BillCarsonFr enabled auto-merge July 15, 2022 12:53
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/stable_withheld branch from f5b3408 to 687c279 Compare July 21, 2022 08:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@BillCarsonFr BillCarsonFr merged commit 00c6ad5 into develop Jul 21, 2022
@BillCarsonFr BillCarsonFr deleted the feature/bca/stable_withheld branch July 21, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mnaturel mnaturel mnaturel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch from org.matrix.room_key.withheld to m.room_key.withheld

3 participants

@BillCarsonFr @mnaturel