Skip to content

Conversation

@S7evinK
Copy link
Collaborator

@S7evinK S7evinK commented Nov 20, 2025

This should help with matrix-org/complement#819

Pull Request Checklist

@S7evinK S7evinK requested a review from a team as a code owner November 20, 2025 07:30
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 22.72727% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.26%. Comparing base (d9c63c8) to head (8e00556).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
userapi/consumers/roomserver.go 22.72% 28 Missing and 6 partials ⚠️

❌ Your patch status has failed because the patch coverage (22.72%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3668      +/-   ##
==========================================
+ Coverage   52.21%   52.26%   +0.05%     
==========================================
  Files         524      524              
  Lines       48376    48399      +23     
==========================================
+ Hits        25258    25298      +40     
+ Misses      19604    19592      -12     
+ Partials     3514     3509       -5     
Flag Coverage Δ
unittests 52.26% <22.72%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on so quickly after the complement test was written 😄

@devonh devonh merged commit 12b7038 into main Nov 21, 2025
35 of 37 checks passed
@devonh devonh deleted the s7evink/handle-room-upgrade branch November 21, 2025 21:40
MadLittleMods added a commit to matrix-org/complement that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants