Merge branch 'JamieLybo-patch-1' into 6.x

Author: russcam

docs/aggregations/pipeline/bucket-script/bucket-script-aggregation-usage.asciidoc

@@ -138,6 +138,7 @@ projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 
 foreach (var item in projectsPerMonth.Buckets)
 {
+    if (item.DocCount == 0) continue;
     var stablePercentage = item.BucketScript("stable_percentage");
     stablePercentage.Should().NotBeNull();
     stablePercentage.Value.Should().HaveValue();

docs/aggregations/pipeline/derivative/derivative-aggregation-usage.asciidoc

@@ -84,12 +84,15 @@ projectsPerMonth.Should().NotBeNull();
 projectsPerMonth.Buckets.Should().NotBeNull();
 projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 
+var notNullDerivativeSeen = 0;
 // derivative not calculated for the first bucket
 foreach (var item in projectsPerMonth.Buckets.Skip(1))
 {
+    if (item.DocCount == 0) continue;
     var commitsDerivative = item.Derivative("commits_derivative");
     commitsDerivative.Should().NotBeNull();
-    commitsDerivative.Value.Should().NotBe(null);
+    if (commitsDerivative.Value != null) notNullDerivativeSeen++;
 }
+notNullDerivativeSeen.Should().BeGreaterThan(0, "atleast one bucket should yield a derivative value surely!");
 ----
 

docs/aggregations/pipeline/moving-average/moving-average-ewma-aggregation-usage.asciidoc

@@ -102,6 +102,7 @@ projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 // average not calculated for the first bucket
 foreach (var item in projectsPerMonth.Buckets.Skip(1))
 {
+    if (item.DocCount == 0) continue;
     var movingAvg = item.MovingAverage("commits_moving_avg");
     movingAvg.Should().NotBeNull();
     movingAvg.Value.Should().BeGreaterThan(0);

docs/aggregations/pipeline/moving-average/moving-average-holt-linear-aggregation-usage.asciidoc

@@ -103,6 +103,7 @@ projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 // average not calculated for the first bucket
 foreach (var item in projectsPerMonth.Buckets.Skip(1))
 {
+    if (item.DocCount == 0) continue;
     var movingAvg = item.MovingAverage("commits_moving_avg");
     movingAvg.Should().NotBeNull();
     movingAvg.Value.Should().BeGreaterThan(0);

docs/aggregations/pipeline/moving-average/moving-average-holt-winters-aggregation-usage.asciidoc

@@ -120,6 +120,7 @@ projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 var bucketCount = 0;
 foreach (var item in projectsPerMonth.Buckets)
 {
+    if (item.DocCount == 0) continue;
     bucketCount++;
 
     var commits = item.Sum("commits");

docs/aggregations/pipeline/moving-average/moving-average-linear-aggregation-usage.asciidoc

@@ -98,6 +98,7 @@ projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 // average not calculated for the first bucket
 foreach (var item in projectsPerMonth.Buckets.Skip(1))
 {
+    if (item.DocCount == 0) continue;
     var movingAvg = item.MovingAverage("commits_moving_avg");
     movingAvg.Should().NotBeNull();
     movingAvg.Value.Should().BeGreaterThan(0);

docs/aggregations/pipeline/moving-average/moving-average-simple-aggregation-usage.asciidoc

@@ -101,6 +101,7 @@ projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 // average not calculated for the first bucket so movingAvg.Value is expected to be null there
 foreach (var item in projectsPerMonth.Buckets.Skip(1))
 {
+    if (item.DocCount == 0) continue;
     var movingAvg = item.Sum("commits_moving_avg");
     movingAvg.Should().NotBeNull();
     movingAvg.Value.Should().BeGreaterThan(0);

docs/aggregations/pipeline/moving-function/moving-function-aggregation-usage.asciidoc

@@ -105,6 +105,7 @@ projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 // average not calculated for the first bucket
 foreach (var item in projectsPerMonth.Buckets.Skip(1))
 {
+    if (item.DocCount == 0) continue;
     var movingAvg = item.Sum("commits_moving_avg");
     movingAvg.Should().NotBeNull();
     movingAvg.Value.Should().BeGreaterThan(0);

docs/aggregations/pipeline/serial-differencing/serial-differencing-aggregation-usage.asciidoc

@@ -91,9 +91,11 @@ projectsPerMonth.Buckets.Count.Should().BeGreaterThan(0);
 
 var differenceCount = 0;
 
+bool atleastOneSecondDifference = false;
 foreach (var item in projectsPerMonth.Buckets)
 {
     differenceCount++;
+    if (item.DocCount == 0) continue;
     var commits = item.Sum("commits");
     commits.Should().NotBeNull();
     commits.Value.Should().NotBe(null);
@@ -104,11 +106,13 @@ foreach (var item in projectsPerMonth.Buckets)
     // only expect values from the 3rd bucket onwards
     if (differenceCount <= 2)
         secondDifference.Should().BeNull();
-    else
+    else if(secondDifference != null)
     {
+        atleastOneSecondDifference = true;
         secondDifference.Should().NotBeNull();
         secondDifference.Value.Should().NotBe(null);
     }
 }
+atleastOneSecondDifference.Should().BeTrue("second_difference should be returned on one bucket atleast!");
 ----
 

docs/client-concepts/connection/configuration-options.asciidoc

@@ -176,31 +176,25 @@ Reasons for such exceptions could be search parser errors, index missing excepti
 
 The following is a list of available connection configuration options on `ConnectionSettings`:
 
-`DefaultFieldNameInferrer`::
+`DefaultDisableIdInference`::
 
-Specify how field names are inferred from POCO property names.
-+
-By default, NEST camel cases property names e.g. EmailAddress POCO property => "emailAddress" Elasticsearch document field name
+`DefaultFieldNameInferrer`::
 
 `DefaultIndex`::
 
-The default index to use when no index is specified.
+`DefaultMappingFor`::
 
 `DefaultMappingFor`::
 
-Specify how the mapping is inferred for a given POCO type. Can be used to infer the index, type, and relation names.
+Specify how the mapping is inferred for a given CLR type. The mapping can infer the index, type and relation name for a given CLR type.
 
 `DefaultTypeName`::
 
-Sets a default type name to use within Elasticsearch for all CLR types. If `DefaultTypeNameInferrer` is also set, a configured             default type name will only be used when `DefaultTypeNameInferrer` returns null or empty. If unset, the default type             name for types will be the lowercased CLR type name.
-
 `DefaultTypeNameInferrer`::
 
-Specify how type names are inferred from POCO types. By default, type names are inferred by calling `ToLowerInvariant` on the type's name.
-
 `InferMappingFor`::
 
-Specify how the mapping is inferred for a given POCO type. Can be used to infer the index, type and relation names. The generic version also allows you to set a default id property and control serialization behavior for properties for the POCO. The type of the document.
+Specify how the mapping is inferred for a given CLR type. The mapping can infer the index, type, id and relation name for a given CLR type, as well as control serialization behaviour for CLR properties.
 
 :xml-docs: Nest:ConnectionSettingsBase`1