feat: validate tag before anything

Signed-off-by: Adrien Mannocci <[email protected]>

Author: amannocci

.github/workflows/pre-post-release.yml

@@ -17,22 +17,6 @@ on:
         - pre
         - post
       required: true
-  workflow_dispatch:
-    inputs:
-      ref:
-        description: 'Branch or tag ref to run the workflow on'
-        required: true
-        default: 'main'
-      version:
-        description: 'The version to release (e.g. 1.2.3). This workflow will automatically perform the required version bumps'
-        required: true
-      phase:
-        description: 'Pre or post release phase'
-        type: choice
-        options:
-          - pre
-          - post
-        default: 'pre'
 
 env:
   RELEASE_VERSION: ${{ inputs.version }}
@@ -45,9 +29,23 @@ concurrency:
   group: ${{ github.workflow }}
 
 jobs:
-  create_pr:
+  validate-tag:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Validate tag does not exist on current commit
+        uses: ./.github/workflows/validate-tag
+        with:
+          tag: ${{ env.RELEASE_VERSION }}
+
+  create-pr:
     name: "Bump versions and create PR"
     runs-on: ubuntu-latest
+    needs:
+      - validate-tag
     permissions:
       contents: write
     steps:

.github/workflows/pre-release.yml

@@ -0,0 +1,26 @@
+---
+name: Pre release
+
+on:
+  workflow_dispatch:
+    inputs:
+      ref:
+        description: 'Branch or tag ref to run the workflow on'
+        required: true
+        default: 'main'
+      version:
+        description: 'The version to release (e.g. 1.2.3). This workflow will automatically perform the required version bumps'
+        required: true
+
+concurrency:
+  group: ${{ github.workflow }}
+
+jobs:
+  pre-release:
+    name: "Bump versions and create PR"
+    uses: ./.github/workflows/pre-post-release.yml
+    with:
+      ref: ${{ inputs.ref }}
+      version: ${{ inputs.version }}
+      phase: 'pre'
+    secrets: inherit

.github/workflows/release.yml

@@ -1,9 +1,6 @@
 ---
 name: Release
 
-permissions:
-  contents: read
-
 on:
   workflow_dispatch:
     inputs:
@@ -19,10 +16,27 @@ on:
         default: false
         type: boolean
 
+permissions:
+  contents: read
+
 jobs:
+  validate-tag:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Validate tag does not exist on current commit
+        uses: ./.github/workflows/validate-tag
+        with:
+          tag: ${{ env.RELEASE_VERSION }}
+
   release:
     name: Release
     runs-on: ubuntu-latest
+    needs:
+      - validate-tag
     steps:
       - id: buildkite
         name: Run Release
@@ -35,7 +49,7 @@ jobs:
           waitFor: true
           printBuildLogs: false
           buildEnvVars: |
-            ref=${{ inputs.ref || 'main' }}
+            ref=${{ inputs.ref }}
             dry_run=${{ inputs.dry_run || 'false' }}
 
       - if: ${{ success() }}
@@ -63,9 +77,8 @@ jobs:
     name: "Bump versions and create PR"
     needs:
       - release
-    permissions:
-      contents: write
     uses: ./.github/workflows/pre-post-release.yml
+    if: inputs.dry_run == 'false'
     with:
       ref: ${{ inputs.ref }}
       version: ${{ inputs.version }}

.github/workflows/validate-tag/action.yml

@@ -0,0 +1,25 @@
+---
+
+name: validate-tag
+description: Validate tag format
+
+inputs:
+  tag:
+    description: 'Tag to validate'
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - name: Validate tag does not exist on current commit
+      id: validate-tag
+      shell: 'bash'
+      run: |
+        if ! [ $(echo "${{ inputs.tag }}" | grep -P "(\d{1,2})\.(\d{1,2})\.(\d{1,2})") ]; then
+          echo "Tag should be a SemVer format"
+          exit 1
+        fi
+        if [ $(git tag -l "${{ inputs.tag }}") ]; then
+          echo "The tag ${{ inputs.tag }} already exists"
+          exit 1
+        fi