Skip to content

Conversation

@t-persson
Copy link
Collaborator

Applicable Issues

N/A

Description of the Change

Make sure we get the input parameters as an array instead of "mushing" them into a string. This makes sure that all parameters are sent to the $COMMAND as they were passed to the executor.sh script, making the script more robust.
When debugging this problem I ran a tool called shellcheck which gave some comments on the script that I fixed as well.

I noticed that a few tests threw a ton of errors in the logs (without failing the tests) that I fixed and I also had to fix a few things that failed when running tox.

Alternate Designs

None!

Possible Drawbacks

This is a change in behavior. It should be more robust, but we don't know if there are any users that depend on the flaky behavior that we have now. We need to test this rigorously and it should be a major release tag on ETOS.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

@t-persson t-persson requested a review from a team as a code owner October 17, 2025 06:55
@t-persson t-persson requested review from andmat900 and fredjn and removed request for a team October 17, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants