Fix a problem where ETR would not respect quotation marks #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
N/A
Description of the Change
Make sure we get the input parameters as an array instead of "mushing" them into a string. This makes sure that all parameters are sent to the $COMMAND as they were passed to the executor.sh script, making the script more robust.
When debugging this problem I ran a tool called
shellcheckwhich gave some comments on the script that I fixed as well.I noticed that a few tests threw a ton of errors in the logs (without failing the tests) that I fixed and I also had to fix a few things that failed when running tox.
Alternate Designs
None!
Possible Drawbacks
This is a change in behavior. It should be more robust, but we don't know if there are any users that depend on the flaky behavior that we have now. We need to test this rigorously and it should be a major release tag on ETOS.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]