Skip to content

Commit 2e7789e

Browse files
markcampanelliEchedey Luis Álvarez
authored and
Echedey Luis Álvarez
committed
Fix failing asv benchmarks in CI (pvlib#2352)
* Pin asv to latest to fix conda install breakage * Update whatsnew * Address reviewer comments
1 parent 9c597a9 commit 2e7789e

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

.github/workflows/asv_check.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,7 @@ jobs:
2626
python-version: '3.9'
2727

2828
- name: Install asv
29-
run: pip install asv==0.4.2
30-
31-
# asv 0.4.2 (and more recent versions as well) creates conda envs
32-
# using the --force option, which was removed in conda 24.3.
33-
# Since ubuntu-latest now comes with conda 24.3 pre-installed,
34-
# using the system's conda will result in error.
35-
# To prevent that, we install an older version.
36-
# TODO: remove this when we eventually upgrade our asv version.
37-
# https://github.com/airspeed-velocity/asv/issues/1396
38-
- name: Install Conda
39-
uses: conda-incubator/setup-miniconda@v3
40-
with:
41-
conda-version: 24.1.2
29+
run: pip install asv==0.6.4
4230

4331
- name: Run asv benchmarks
4432
run: |

docs/sphinx/source/whatsnew/v0.11.3.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,12 @@ Requirements
2424
~~~~~~~~~~~~
2525

2626

27-
Contributors
28-
~~~~~~~~~~~~
27+
Maintenance
28+
~~~~~~~~~~~
29+
* asv 0.4.2 upgraded to asv 0.6.4 to fix CI failure due to pinned older conda.
30+
(pull:`2352`)
2931

3032

33+
Contributors
34+
~~~~~~~~~~~~
35+
* Mark Campanelli (:ghuser:`markcampanelli`)

0 commit comments

Comments
 (0)