Skip to content

Cell weights not distinguishable when zoomed out #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ernstaii opened this issue Jun 11, 2024 · 4 comments · May be fixed by #32
Open

Cell weights not distinguishable when zoomed out #31

ernstaii opened this issue Jun 11, 2024 · 4 comments · May be fixed by #32

Comments

@ernstaii
Copy link

When zooming out for a big DSM, cell weight are not readable anymore. Cells with and those without weights are not easily distinguishable.
I suggest to change the cell visualisation so the lower half of the cell is a coloured bar (themed, set to black) that grows with the weight of the cell. This way, the user quickly sees which cells contain a dependency even when the cells are very small. Do you want a PR for this?

@jmuijsenberg
Copy link
Member

I would prefer simply giving cell with weight another background color. Preferably a darker variant of the existing cell color. You would then be able see if the cell has a weight or not. That would meet your requirement.

There are two reasons I prefer not to use the idea of a colored bar:

  1. It is not clear what weight would represent a maximum filled bar.
  2. Small weight may lead to a to small bar. Again invisible just as the numbers.
  3. I used color bar in the DSM once, but found it too much visual clutter and therefore chose another approach in the end.

I you agree I can make an update next weekend.

@ernstaii
Copy link
Author

Here's an example (at the minimum zoom level) where the bar represents quantiles of 10%. Even dependency weight 1 is visible and the bar is full for the top 10%. This scales nicely with what the matrix currently displays. The exact number is still visible in the cell and of course in the tooltip. Granted, the black bar is a bit intense, but dark grey would also work.
image

And here's a version where the cells themselves are darkened (binary, independent of actual weight). The disadvantages I see here are

  1. Many different background colours. The basic 4, and darkened for weights, lightened for the selection and then there's the hovered cell. What happens when a banding algorithm is added?
  2. The contrast between background and text gets too low for dark cells, so you'd have to change the letter colouring which makes the whole display less eye-friendly.
  3. Neighbouring cells with different backgrounds but both darkened get very similar. The user can only distinguish them because the mind draws boxes around other cells without weight, whose colour is more distinguisable.
    image

Here's the bar again with dark grey instead of black. Looks better, IMHO.
image

@ernstaii ernstaii linked a pull request Jul 22, 2024 that will close this issue
@jmuijsenberg
Copy link
Member

Thanks for all effort put in the 4 pull requests. Currently not having much time available. Will look into these when I have some time.

@jmuijsenberg
Copy link
Member

I you have other feedback on the usage of the tool please let me know. I see you added TODO in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants