Skip to content

Add SupportsEquality interface #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Aug 7, 2020 · 0 comments · Fixed by #543
Closed

Add SupportsEquality interface #541

sobolevn opened this issue Aug 7, 2020 · 0 comments · Fixed by #543
Labels
enhancement New feature or request

Comments

@sobolevn
Copy link
Member

sobolevn commented Aug 7, 2020

Not all containers support real equality check. Sometimes we need to know what exactly can be compared.
For example:

  • IO.from_value(1) == IO.from_value(1)
  • Future.from_value(1) != Future.from_value(1)

We can add equals alias to __eq__ for types that do support real equality.
We also need to support Equality laws. See #533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds monad laws and a tool to check them dry-python/returns
1 participant
@sobolevn