From 578a48a1cfac5cf469373e94ad45a58a4bda31bf Mon Sep 17 00:00:00 2001 From: Philippe Pepiot Date: Fri, 11 Jun 2021 12:32:52 +0200 Subject: [PATCH] Fix sqlalchemy.ddl.DDL.execute_if dialect type (#181) dialect should be a string a list/tuple/set of strings. Not a Dialect object. https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_4_18/lib/sqlalchemy/sql/ddl.py#L158 Closes #181 --- sqlalchemy-stubs/sql/ddl.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sqlalchemy-stubs/sql/ddl.pyi b/sqlalchemy-stubs/sql/ddl.pyi index b808262..0e44cb0 100644 --- a/sqlalchemy-stubs/sql/ddl.pyi +++ b/sqlalchemy-stubs/sql/ddl.pyi @@ -33,7 +33,7 @@ class DDLElement(Executable, _DDLCompiles): def execute_at(self, event_name: str, target: SchemaItem) -> None: ... def against(self: _DDLE, target: SchemaItem) -> _DDLE: ... state: Any = ... - def execute_if(self: _DDLE, dialect: Optional[Dialect] = ..., callable_: Optional[_DDLCallable] = ..., + def execute_if(self: _DDLE, dialect: Optional[Union[str, Sequence[str]]] = ..., callable_: Optional[_DDLCallable] = ..., state: Optional[Any] = ...) -> _DDLE: ... def __call__(self, target: Optional[Union[Table, MetaData]], bind: Connection, **kw: Any) -> Optional[ResultProxy]: ...