Skip to content

Conversation

@rogebrd
Copy link
Contributor

@rogebrd rogebrd commented Feb 26, 2021

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #329 (bfb5305) into main (74e51e1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   63.60%   63.60%           
=======================================
  Files          30       30           
  Lines       49374    49374           
  Branches     3623     3623           
=======================================
  Hits        31404    31404           
  Misses      17942    17942           
  Partials       28       28           
Flag Coverage Δ
unit 63.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e51e1...f796ba1. Read the comment docs.

@rogebrd rogebrd merged commit 1569026 into main Mar 5, 2021
@rogebrd rogebrd deleted the dep_update branch March 5, 2021 18:46
@marmarek
Copy link

marmarek commented Mar 8, 2021

This resulted in adding twine in install_reqs, which then pulled in several other dependencies. Is that really necessary at runtime (as opposed from dev env)?

@greg-db
Copy link
Contributor

greg-db commented Mar 8, 2021

@marmarek Thanks for the note! I'll ask the team to see if this is needed and if we can change that.

@greg-db
Copy link
Contributor

greg-db commented Mar 9, 2021

@marmarek We've updated install_reqs to no longer pull in from requirements.txt.

@marmarek
Copy link

marmarek commented Mar 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants